Your message dated Fri, 13 Apr 2012 06:02:29 +0000
with message-id <e1sizax-0005yx...@franck.debian.org>
and subject line Bug#667836: fixed in amanda 1:3.3.1-3
has caused the Debian Bug report #667836,
regarding FTBFS on kfreebsd-*
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
667836: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667836
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: amanda
Version: 3.3.1-2
Severity: serious
Tags: patch
Justification: fails to build from source (but built successfully in the past)
See: http://lists.debian.org/debian-bsd/2012/04/msg00093.html
The glib init code is completely obsolete. g_thread_supported() is now a stub
which always returns 1, so the first assertion doesn't make sense.
And g_thread_init() is just a dummy stub, so it's no use to call it.
These two provisions were put there to prevent some problem with multithreading
and libcurl, but they don't have any effect now (other than breaking things), so
it makes no sense to enable them.
As to what they were trying to prevent, perhaps they were just meant to work
around thread unsafety in curl_global_init()? If that's the case, a mutex
sounds like the right thing to do. Then again, I doubt it's really necessary.
Why would curl_global_init() be re-entered if amanda hasn't spawned new
threads yet?
-- System Information:
Debian Release: 6.0.4
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: kfreebsd-amd64 (x86_64)
Kernel: kFreeBSD 8.1-1-amd64
Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
=== modified file 'common-src/glib-util.c'
--- common-src/glib-util.c 2012-04-06 21:45:36 +0000
+++ common-src/glib-util.c 2012-04-06 21:49:13 +0000
@@ -38,12 +38,8 @@ glib_init(void) {
if (did_glib_init) return;
did_glib_init = TRUE;
- /* set up libcurl (this must happen before threading
- * is initialized) */
+ /* set up libcurl */
#ifdef HAVE_LIBCURL
-# ifdef G_THREADS_ENABLED
- g_assert(!g_thread_supported()); /* assert threads aren't initialized yet */
-# endif
g_assert(curl_global_init(CURL_GLOBAL_ALL) == 0);
#endif
@@ -64,12 +60,6 @@ glib_init(void) {
/* Initialize glib's type system. On glib >= 2.24, this will initialize
* threads, so it must be done after curl is initialized. */
g_type_init();
-
- /* And set up glib's threads */
-#if defined(G_THREADS_ENABLED) && !defined(G_THREADS_IMPL_NONE)
- if (!g_thread_supported())
- g_thread_init(NULL);
-#endif
}
typedef enum {
--- End Message ---
--- Begin Message ---
Source: amanda
Source-Version: 1:3.3.1-3
We believe that the bug you reported is fixed in the latest version of
amanda, which is due to be installed in the Debian FTP archive:
amanda-client_3.3.1-3_i386.deb
to main/a/amanda/amanda-client_3.3.1-3_i386.deb
amanda-common_3.3.1-3_i386.deb
to main/a/amanda/amanda-common_3.3.1-3_i386.deb
amanda-server_3.3.1-3_i386.deb
to main/a/amanda/amanda-server_3.3.1-3_i386.deb
amanda_3.3.1-3.debian.tar.gz
to main/a/amanda/amanda_3.3.1-3.debian.tar.gz
amanda_3.3.1-3.dsc
to main/a/amanda/amanda_3.3.1-3.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 667...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bdale Garbee <bd...@gag.com> (supplier of updated amanda package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 12 Apr 2012 23:29:14 -0600
Source: amanda
Binary: amanda-common amanda-server amanda-client
Architecture: source i386
Version: 1:3.3.1-3
Distribution: unstable
Urgency: low
Maintainer: Bdale Garbee <bd...@gag.com>
Changed-By: Bdale Garbee <bd...@gag.com>
Description:
amanda-client - Advanced Maryland Automatic Network Disk Archiver (Client)
amanda-common - Advanced Maryland Automatic Network Disk Archiver (Libs)
amanda-server - Advanced Maryland Automatic Network Disk Archiver (Server)
Closes: 666088 667836
Changes:
amanda (1:3.3.1-3) unstable; urgency=low
.
* patch from Robert Milan to fix kfreebsd FTBFS, closes: #667836
* patch from amanda-users mailing list via Jose Manuel dos Santos Calhariz
that fixes amrecover issue with VTAPE access, closes: #666088
Checksums-Sha1:
53d636614e707d3859972d64868103609a0960c7 2061 amanda_3.3.1-3.dsc
466f760e43cdb191c0780e0cd82ef08b03fd06ff 31419 amanda_3.3.1-3.debian.tar.gz
6e7b71eaea23385b3ab127e06a3251619f3e6bf3 2181710 amanda-common_3.3.1-3_i386.deb
9441c8cccc0f162edcf48c523843430570051aed 351348 amanda-server_3.3.1-3_i386.deb
4d467067ee6a3dd0f8928258663f53c9dd1e4335 267130 amanda-client_3.3.1-3_i386.deb
Checksums-Sha256:
49e1fc9ce456bc28896b0cf5f39f5265228d10305965e74f1062a7a26acfd04c 2061
amanda_3.3.1-3.dsc
12683db53a49e309b7d2d6dd815d6a42d7ada7ea77f5aa55bdcbd16663e853bf 31419
amanda_3.3.1-3.debian.tar.gz
f076c037efe6616d2adfdbc4ca4d1ec6fc717821a1570076aafbec2e6c73e1ff 2181710
amanda-common_3.3.1-3_i386.deb
b6baf6c61663694d350ee14d7ba72edfece926de5d492ae91f3d5058d6f1ef1b 351348
amanda-server_3.3.1-3_i386.deb
8deb344f191c3f305c4ea10d84bf4956042383ef8913662b427a5e0df0db3696 267130
amanda-client_3.3.1-3_i386.deb
Files:
6a5ff562615a7a5385905299b5990e35 2061 utils optional amanda_3.3.1-3.dsc
36a0ad51ca89169f66c3e7b92267756a 31419 utils optional
amanda_3.3.1-3.debian.tar.gz
ab08d72213f64f84f1682eace645c17c 2181710 utils optional
amanda-common_3.3.1-3_i386.deb
eabbf54eaf5fdeb8289344f28226177c 351348 utils optional
amanda-server_3.3.1-3_i386.deb
e5827f51834b438f6b0cbd98c959506f 267130 utils optional
amanda-client_3.3.1-3_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIVAwUBT4e97zqTYZbAldlBAQrm+RAAyVVvqlI84rACdOcWBMWJ/4zsJnECqAiV
HCpCbEfj6p0uKgV5L9ujckjmfHL6wPbtuVtbctPquHRRGKE6vKxvWuWEwN6ljV//
Tm8Mm+40Be5n7zwXnb9n7sXYDH/7SfYw5X8lwtoHjevgXKGqX4dLE8hsoaXT9y/a
uq0y2DmI+B755ql7rGSTWXwDhje9JQGyo8GdOldwqKeo0GR+Mvnc14/VhIHflcIK
3QvCJm0LM8Rs3htEBBTruIiQOcDqhceP6L0ZLreT4AJQnR7aBKXoC7etdOiXwCJR
6Lv/4m12CxCYjUbotJ9hD8EcNKSbWDZ+uQw+UNVXuE63Z+jwYuHDSFzJh2dE7Lkz
viPfA1h61bz3nk/BfprFaR7BkLTLw6H2ojubn51pCjTOcY4OyzE9X47zF7QItkzS
GOqsA0wMVpZxyiwohQr2vXqX+WOmfZpqZDyQPVCjXg3JbFdjAZCxuP6KvM1Bz0Jm
A28ZAA9cSI4jVGP6gZKdID56XWmstcna/JPgXS5QdJGpcXNlt7RpmZJJrynkxxNA
U6I3/zIG+hZSHtgEFSAXsuDEg49Q2+J3pNQvLbtH74Lh9l/MBkrzJY9IUrWX5t/b
1DF5DNckAgxXWBV7IQ7anG8C2vVrtElW1c5FOEHzlx40XLawval4ixByLW6a28bu
rMQ6QST2Li0=
=hazu
-----END PGP SIGNATURE-----
--- End Message ---
