Your message dated Fri, 23 Mar 2012 22:32:55 +0000
with message-id <e1sbd2v-0002w0...@franck.debian.org>
and subject line Bug#665383: fixed in mawk 1.3.3-17
has caused the Debian Bug report #665383,
regarding Source and destination overlap in memcpy
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
665383: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=665383
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: mawk
Version: 1.3.3-16
Severity: serious
Tags: upstream patch

Hi,

RC because this causes at least one other package to FTBFS with the current
libc in sid.  See #628247 for more details of that.

We'd originally thought that was due to the output files being mashed during
parallel builds, but the most recent rebuilds that Lucas did also proved that
the exact same results could be reproduced with current libc on a single core
system with a -j1 build.

After further investigation, it turns out the recent changes to memcpy in libc
have triggered a latent bug in mawk, making it mash the memory copied between
overlapping regions.

The existence of the bug in mawk was confirmed by valgrind, and the following
patch is confirmed to fix the error that resulted from it.  The code paths in
mawk exercised by sofia-sip don't shake out any other instances of this, but
I haven't exhaustively scanned the mawk code for any others at this stage.

Cheers,
Ron


--- fin.c.orig  2012-03-24 02:40:41.000000000 +1030
+++ fin.c       2012-03-24 02:40:46.000000000 +1030
@@ -328,7 +328,7 @@
       /* move a partial line to front of buffer and try again */
       unsigned rr ;
 
-      p = (char *) memcpy(fin->buff, p, r = strlen(p)) ;
+      p = (char *) memmove(fin->buff, p, r = strlen(p)) ;
       q = p+r ;         rr = fin->nbuffs*BUFFSZ - r ;
 
       if ((r = fillbuff(fin->fd, q, rr)) < rr)



--- End Message ---
--- Begin Message ---
Source: mawk
Source-Version: 1.3.3-17

We believe that the bug you reported is fixed in the latest version of
mawk, which is due to be installed in the Debian FTP archive:

mawk_1.3.3-17.diff.gz
  to main/m/mawk/mawk_1.3.3-17.diff.gz
mawk_1.3.3-17.dsc
  to main/m/mawk/mawk_1.3.3-17.dsc
mawk_1.3.3-17_amd64.deb
  to main/m/mawk/mawk_1.3.3-17_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 665...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Steve Langasek <vor...@debian.org> (supplier of updated mawk package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 23 Mar 2012 13:15:00 -0700
Source: mawk
Binary: mawk
Architecture: source amd64
Version: 1.3.3-17
Distribution: unstable
Urgency: low
Maintainer: Steve Langasek <vor...@debian.org>
Changed-By: Steve Langasek <vor...@debian.org>
Description: 
 mawk       - a pattern scanning and text processing language
Closes: 391051 665383
Changes: 
 mawk (1.3.3-17) unstable; urgency=low
 .
   * debian/patches/cross-compile: fix the wrong invocation of AC_CHECK_PROG()
     that breaks cross-compiler detection.
   * debian/patches/21_memcpy-to-memmove: use memmove instead of memcpy in
     FINgets.  Closes: #665383, LP: #955791.
   * mark mawk Multi-Arch: foreign, to satisfy cross-build-dependencies.
   * debian/patches/20_overlong-regexps: Do not crash if regexp is too
     long for our buffer.  Thanks to Ian Jackson <i...@ubuntu.com>,
     Jonathan Nieder <jrnie...@gmail.com>.  Closes: #391051, LP: #23494.
   * add autopkgtest/autodebtest support to run upstream tests.
Checksums-Sha1: 
 2bddcbeafcdf66bd461617f7761b0a9d93a8b19e 1801 mawk_1.3.3-17.dsc
 a280d211a2da54fd861012cf55dbdc90ab522e18 63506 mawk_1.3.3-17.diff.gz
 19705b41cf82ace4fae6cb1dc5f5e90f61fcfc28 90816 mawk_1.3.3-17_amd64.deb
Checksums-Sha256: 
 f98ce6e153e8ac1faf8165bbf77447a4279313f1c18f6bfeec0c5ce35e4b9c03 1801 
mawk_1.3.3-17.dsc
 13cb66b6eb5ee654d5626621d5ef476ede6b0bebac18ce765516de810e58490c 63506 
mawk_1.3.3-17.diff.gz
 cb383c9b0a158c8c045e7fc2e0735f78f5ed73c8dfb74f23c5c4dd4a85d008d0 90816 
mawk_1.3.3-17_amd64.deb
Files: 
 92f6792d065ab4932b545fdf0f139132 1801 interpreters required mawk_1.3.3-17.dsc
 70929584abfc813f0bc31d0bc77f0f4f 63506 interpreters required 
mawk_1.3.3-17.diff.gz
 30b0681b565ac6ecbf6cea0a84f318a9 90816 interpreters required 
mawk_1.3.3-17_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIVAwUBT2z3ilaNMPMhshM9AQjyeg/9Hn1sGARWlz845DNje07zGfvwqR0Tsi6k
nBBDsCjzXWTLK/bDC+pkM9OK9Kgf2l5EAc4+gbBmGSgnwOYWftG5vWngNc1ziX4i
OL9f6sh9FWiIpgLHw7xixOmx/7fotfJBCg5RZzLi6Q5MQ5Rtyyj61oyx+e9K1wAv
YVxJ0YMTfApa4UzJa+I0eMsZMUv2Plgo+Df412a86OMY3Mz5qiQDSmHcNgcAB/J3
YrbvIUvgus5NvtJWZBawI+hU8Co4WiLZmPlsr39hr9q1OsOzso9SQ7l2RV9sjc/W
90cT3mLRwwkYmBMmIklkMcqmXemvyQzKQ04QoqZ8x7C9EFqONlfw70ok4JsrNNaG
8CIK9KyeECb8idTGNQUWbIKo616zEspbKryo3t/CXOhVGQmsdb/mqOyJIOvJjMJb
oj7MrL4PzLLK8p7U6klvnyX3B3U/r5q9/BAgvS3tcTEbqQElYOG2YrtuCPTywk81
2C4R1IMWlxTIbN9rPw9lEt+y3yXbW2WXuI8An7ayFCoik9Xr9s+zx4j4e8TNwSV6
YGrJ4p1Vc5/idZZceD+e7nU6avaITyAT55pj7f2CSKGaoOWK9GOVSuk700ZP+s+c
54XLRn2Lq237OAQXUd2o7VceStrlYqPYvSj0a/Q40CIzl/jd65nTfa90JLqrTJO/
uFiHuD3kE60=
=0u2o
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to