Your message dated Wed, 07 Mar 2012 02:56:09 +0000
with message-id <e1s572v-0006uj...@franck.debian.org>
and subject line Bug#660947: fixed in lebiniou 3.15-1.1
has caused the Debian Bug report #660947,
regarding lebiniou FTBFS on architectures where char is unsigned.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
660947: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=660947
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
package: lebiniou
severity: serious
tags: patch
version: 3.15-1
lebiniou FTBFS on armel, armhf, powerpc, s390 and s390x with the
following error.
make[6]: Entering directory
`/build/buildd-lebiniou_3.15-1-armhf-gOcAq_/lebiniou-3.15/plugins/stable/main/speaker'
CC speaker_so-speaker.o
speaker.c: In function 'run':
speaker.c:108:3: error: comparison is always false due to limited range
of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
The common thing about these architectures is they have char unsigned by
default.
Anyway I found the offending variable of type char called volume. I
fixed the issue by changing the types of the variable and the typecast
(from float) used to set the variable to "signed char". I believe this
is a correct fix from looking at the code but I do not have any
experience with the package.
Patch and series file are attatched, just create debian/patches and drop
them in (the package uses 3.0 (quilt) but currently has no patches)
Description: fix error on systems with signed char
The code this patch changes was causing a "comparison is always false" error
on systems where char defaults to unsigned.
Author: Peter Green <plugw...@p10link.net>
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>
--- lebiniou-3.15.orig/plugins/stable/main/speaker/speaker.c
+++ lebiniou-3.15/plugins/stable/main/speaker/speaker.c
@@ -96,12 +96,12 @@ destroy(__attribute__ ((unused)) Context
void
run(Context_t *ctx)
{
- char volume;
+ signed char volume;
if (ctx->input == NULL)
return;
- volume = (char)(Input_get_volume(ctx->input) * 10);
+ volume = (signed char)(Input_get_volume(ctx->input) * 10);
if (volume >= NB_FCT)
volume = NB_FCT-1;
fix-char-signdness.patch
--- End Message ---
--- Begin Message ---
Source: lebiniou
Source-Version: 3.15-1.1
We believe that the bug you reported is fixed in the latest version of
lebiniou, which is due to be installed in the Debian FTP archive:
lebiniou_3.15-1.1.debian.tar.gz
to main/l/lebiniou/lebiniou_3.15-1.1.debian.tar.gz
lebiniou_3.15-1.1.dsc
to main/l/lebiniou/lebiniou_3.15-1.1.dsc
lebiniou_3.15-1.1_armel.deb
to main/l/lebiniou/lebiniou_3.15-1.1_armel.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 660...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Hector Oron <zu...@debian.org> (supplier of updated lebiniou package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 05 Mar 2012 01:07:16 +0000
Source: lebiniou
Binary: lebiniou
Architecture: source armel
Version: 3.15-1.1
Distribution: unstable
Urgency: low
Maintainer: Olivier Girondel <oliv...@biniou.info>
Changed-By: Hector Oron <zu...@debian.org>
Description:
lebiniou - displays images that evolve with sound
Closes: 660947
Changes:
lebiniou (3.15-1.1) unstable; urgency=low
.
* Non-maintainer upload.
* Fix "lebiniou FTBFS on architectures where char is unsigned."
- Thanks Peter Green (Closes: #660947)
Checksums-Sha1:
de7f66d0572093fd38b8ad5cc6889a2c44ab2808 1802 lebiniou_3.15-1.1.dsc
27917deaaf9606525da5dd5e5d8a3de085779d24 4293 lebiniou_3.15-1.1.debian.tar.gz
61ea5a0cf5912a6bbc37bc3ff44dda21356ee785 399838 lebiniou_3.15-1.1_armel.deb
Checksums-Sha256:
4665750812d4b202d9fea0c0d7df35dd8e5cd423123cf769e30a839d2b5e7015 1802
lebiniou_3.15-1.1.dsc
86b5d97fda8372cb8965a9015aa7bcc8f0983bb4110633e21aafa4506917ac98 4293
lebiniou_3.15-1.1.debian.tar.gz
80ec89b2915032985c70cf2d65d8e68636fa541fefda1552f9383d4c23ead3c1 399838
lebiniou_3.15-1.1_armel.deb
Files:
e8ebda19aac9bf14e389a68ced0d825c 1802 graphics extra lebiniou_3.15-1.1.dsc
aec357a82e0550700fed5f0b827ef341 4293 graphics extra
lebiniou_3.15-1.1.debian.tar.gz
d941f2dd8ba83a014b393bbf57b5a5ff 399838 graphics extra
lebiniou_3.15-1.1_armel.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCgAGBQJPVBm1AAoJEK8ig6p24qx7VP4P/26e4tmmRPz8JBVNe/KVbc1Z
+6Kxtfqrukq3thC8vAndIVxO8lVnIlWjgBR4LNXSu7ESO1rcAOIkb9/Sxau+mCZH
iuag19BI0iceM2HF5u7fCiQ1FcOgH1wxy3GCTMyZsJUVeozgJdnv/311ZP6xINri
tLHmgw72L67r7bIHnOcuZAz5XGxzai1E9jYVthgQJyEOodC3GYUj+iFn4iXWUQ72
2wvXi/KJKMK1qkNS8f+Y5mklV3Zvd6jNVsvp1+OSRaaZf4h0wghRTW838W7kLEov
SbmJFUoALTSyygTu/04VrHbk6/8UoMTQtnSetMYGPwRA9NE9HyOdER5LLjCc/Xya
E8Z947GC1z9DYeOyX10CGmNwvbzQaPeETnhBh0zYsv7dzCbVKZoqPmkMJr2O0Vt/
pJl8hi0X/HguEYPh/1hWsq0s4N3XRzJBsls/n7/5D4PfXmNi/Au9FfWM2VXJQH30
sBWcqxQuJ6r3MpPe3jlYI0uuFMQzBjUTxf6Mk15lLoyJqdW7pkvoTI88+ZI5OjxU
9bSFhhbiTm9K3nsvSvu+5XkN9CXM2Fu3BXxVI5AF7RN/TnYMoVgWfN+3mX34TMEj
GD4MxPejf+lvvHW5t+TTx5z2i0mPyfhYhHwlqkUYpDU/nGNrmX11GKTjkBnKvYba
b0DGMVDtjXxDQ/Y5POAq
=8zZA
-----END PGP SIGNATURE-----
--- End Message ---
