Package: nautic Version: 1.3-6 Severity: serious Justification: Broken use of source format, poor packaging rules
I came across nautic because there is a release-critical bug applied to the package which is still open but it looks as if the package has been fixed. Upon reviewing the package, I found a number of problems. 0: The debian/changelog needs to actually describe the changes - not "adjustments". The changelog also needs to be updated using debchange with the --closes argument to say which bugs are being closed. This would have prevented bug #637689 from still being open. 1: lintian warnings should be fixed and the ones in this package are simple to fix. 2: One of the lintian warnings relates to the patches which are, actually, completely unnecessary. A few changes to debian/rules and the patches go away. There is never a need to patch generated files and your package should have been regenerating Makefile.in anyway. There never was any need for the package to contain ltmain.sh, let alone change it in a patch, as no library is being built. 3: The watch file does not work but is simple to fix. 4: There is an upstream version which only adds to the problems because it is a different file: 1.3.orig.tar.gz The original tarball checksums can be seen here: http://packages.qa.debian.org/n/nautic/news/20110812T190307Z.html 3c06aff06312b4b616af20eb227d46849638a64e7a2a8966011ff7a6ea12cc0e 407867 nautic_1.3.orig.tar.gz The tarball I downloaded from SF for the 1.3-7 version DIFFERS: 205039e6e515126be22c8b3d3daed8fc8cb0f5cb80594a0196eeeffc7e73f051 nautic_1.3.orig.tar.gz Those MUST be the same file. If you change ANYTHING which goes into the upstream (.orig.tar.gz) tarball at SourceForge, you make a new upstream release which will be 1.4-1 not 1.3-7. Otherwise, your 1.3-7 upload to Debian will be either rejected or will simply not contain what you expect. i.e. the changes made in upstream include: src/about.cpp | 2 - src/un_known_star.cpp | 18 +++++------------ If you had uploaded 1.3-7 in that state, it would have been compiled without these changes. It is also unnecessary to repack the nautic tarball just to set the directory name to package-version, the tools work with that without problems. Frankly, nautic is in such a bad state for the packaging that I was close to asking for the removal of the package and I am very unclear on whether the package should be allowed to migrate into testing. For now, this bug will replace the original RC bug to keep nautic out of testing. Please fix this package properly, talk to people on debian-ment...@lists.debian.org and ask for a review of the package as it currently is in the archive. Version 1.3-6 is NOT in a satisfactory state in Debian. You should also take down 1.3-7 from sourceforge and redo it as 1.4 (without the debian version), taking advice from debian-mentors to fix all of the issues before the next upload. If you are at all unclear then seek a package review by a sponsor using the debian-mentors mailing list. My changes to make a more suitable package result in these changed files: $ cat debian/watch version=3 http://sf.net/nauticalmanac/nautic_(.+)\.orig\.tar\.gz $ cat debian/rules #!/usr/bin/make -f # -*- makefile -*- # Sample debian/rules that uses debhelper. # This file was originally written by Joey Hess and Craig Small. # As a special exception, when this file is copied by dh-make into a # dh-make output file, you may use that output file without restriction. # This special exception was added by Craig Small in version 0.37 of dh-make. # Uncomment this to turn on verbose mode. #export DH_VERBOSE=1 %: dh $@ override_dh_clean: dh_clean rm -f config.guess config.sub config.log config.status $(RM) ltmain.sh Makefile.in configure $(RM) aclocal.m4 data/Makefile.in icon/Makefile.in $(RM) info/Makefile.in man/Makefile.in src/Makefile.in override_dh_auto_configure: autoreconf -fs dh_auto_configure Then remove everything from debian/patches. (debian/patches is only for changes outside the debian directory and even then, not for files generated / modified by autoreconf.) One lintian warning in debian/control fixed with: Build-Depends: debhelper (>= 7.0.50~), Please note, I'm not actually sponsoring packages currently. Any further questions or problems need to be discussed with the debian-mentors mailing list. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
