Am Donnerstag, den 01.03.2012, 16:24 +0100 schrieb Cyril Brulebois: > Hi Benjamin and others, > > as you know I have been spending countless hours trying to get vlc to > build on kfreebsd to unfuck some transitions.
Thanks for this work. > I was finally getting at a > working patch (part of it *from upstream*), while you uploaded the > (upstream) patch with another change which basically reverts its effect. > (Hint: --as-needed) I wasn't aware that --as-needed breaks the patch. As part of enabling hardening flags I moved the --as-needed flag, but wasn't aware, that the flag previously didn't work as expected. > You'll find attached the patch I prepared and which has been tested both > on kfreebsd and on linux. > > > (On a personal note, next time, please don't blame me for: Sorry for being suggestive of blaming you. I didn't intend to blame you. I only wanted to notify you. > - your failure to attribute the patch to its actual author; > - your failure to wait for the patch I said I was polishing, and > actually testing on a porter box; I modified the Makefiles manually and ran a test, but I wasn't carefully enough. > - your basically reverting the patch through an extra link flag. > > I realize I'm probably sounding angry. But that's the current state of > affairs.) I fixed the package and doing a testbuild. Once it succeeds, I will do another upload and hopefully it will build on all arch then. -- Benjamin Drung Debian & Ubuntu Developer
signature.asc
Description: This is a digitally signed message part
