Package: backintime-common Version: 1.0.8-1 Severity: grave Tags: patch Justification: potential data loss
I hadn't checked that my backups were working recently, and to my horror discovered that nothing had been backed up since I last checked. The reason for this? There was a directory with permissions 1354 (!!), and rsync couldn't deal with this. So rsync bombed out with an error and backintime therefore decided that the backup had failed and deleted the new_backup directory. But there was no warning - cron didn't give an error message or anything. Proposals: (i) Remove the "2>&1" from the crontab entry (patch attached); this way, warnings will be emailed. (ii) If the backup fails, backintime should exit with a big fat warning message and probably a non-zero exit code. Thanks! Julian -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (990, 'testing'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages backintime-common depends on: ii cron 3.0pl1-121 ii python 2.7.2-10 ii rsync 3.0.9-1 backintime-common recommends no packages. backintime-common suggests no packages. -- no debconf information
--- /usr/share/backintime/common/config.py 2011-07-05 21:46:55.000000000 +0100 +++ /tmp/config.py 2012-02-15 11:36:19.000000000 +0000 @@ -820,7 +820,7 @@ profile='' if '1' != profile_id: profile = "--profile-id %s" % profile_id - cmd = "/usr/bin/backintime %s --backup-job >/dev/null 2>&1" % profile + cmd = "/usr/bin/backintime %s --backup-job >/dev/null" % profile if self.is_run_ionice_from_cron_enabled(): cmd = 'ionice -c2 -n7 ' + cmd if self.is_run_nice_from_cron_enabled( profile_id ):