tags 643464 + patch tags 643464 + pending thanks Dear maintainer,
I've prepared an NMU for radeontool (versioned as 1.6.2-1.1) and uploaded it to DELAYED/2. Please feel free to tell me if I should delay it longer. Regards. -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Solomon Burke: Don't Give Up On Me
diff -Nru radeontool-1.6.2/debian/changelog radeontool-1.6.2/debian/changelog --- radeontool-1.6.2/debian/changelog 2011-09-02 13:11:20.000000000 +0200 +++ radeontool-1.6.2/debian/changelog 2012-01-27 15:36:12.000000000 +0100 @@ -1,3 +1,12 @@ +radeontool (1.6.2-1.1) unstable; urgency=low + + * Non-maintainer upload. + * Fix "FTBFS: radeontool.c:42:5: error: format not a string literal and no + format arguments": add patch from Jonathan Nieder (adds format arguments). + Closes: #643464 + + -- gregor herrmann <gre...@debian.org> Fri, 27 Jan 2012 15:27:43 +0100 + radeontool (1.6.2-1) unstable; urgency=low [ Jonathan Nieder ] diff -Nru radeontool-1.6.2/debian/patches/format-security.patch radeontool-1.6.2/debian/patches/format-security.patch --- radeontool-1.6.2/debian/patches/format-security.patch 1970-01-01 01:00:00.000000000 +0100 +++ radeontool-1.6.2/debian/patches/format-security.patch 2012-01-27 15:27:37.000000000 +0100 @@ -0,0 +1,43 @@ +Subject: avoid -Wformat-security warnings +Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=643464 + +fatal() is never called with a user-specified argument so it is safe +to pass its argument as an fprintf format string, but gcc doesn't know +that. Using fprintf(stderr, "%s", arg) makes the intent clearer. + +Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> +--- +Thanks, +Jonathan + + avivotool.c | 2 +- + radeonreg.c | 2 +- + radeontool.c | 2 +- + 3 files changed, 3 insertions(+), 3 deletions(-) + +Index: b/avivotool.c +=================================================================== +--- a/avivotool.c ++++ b/avivotool.c +@@ -64,7 +64,7 @@ + + static void fatal(char *why) + { +- fprintf(stderr, why); ++ fprintf(stderr, "%s", why); + pci_system_cleanup(); + + } +Index: b/radeontool.c +=================================================================== +--- a/radeontool.c ++++ b/radeontool.c +@@ -39,7 +39,7 @@ + static void radeon_rom_legacy_mmio_table(unsigned char *bios, int offset); + static void fatal(char *why) + { +- fprintf(stderr,why); ++ fprintf(stderr, "%s", why); + pci_system_cleanup(); + exit(-1); + } diff -Nru radeontool-1.6.2/debian/patches/series radeontool-1.6.2/debian/patches/series --- radeontool-1.6.2/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ radeontool-1.6.2/debian/patches/series 2012-01-27 15:27:37.000000000 +0100 @@ -0,0 +1 @@ +format-security.patch
signature.asc
Description: Digital signature
