Thank you for in-depth look into this bug. Niels or Matthew, any concerns with me preparing an upload?
Thanks,
tony
On 01/05/2012 08:14 PM, Wookey wrote:
>
> This seems to me to be a serious problem blocking all
> java-helper-using packages
>
> So, I took a look at what's going on and found the following:
<--snip-->
> We can fix it by explicitly removing and recreating it:
>
> verbose_print("Updating manifest in $jar");
> $zip->removeMember( 'META-INF/MANIFEST.MF' ) unless($new_manifest);
> $zip->removeMember( 'META-INF/' );
> $mem = $zip->addString($var, 'META-INF/MANIFEST.MF');
> $mem->desiredCompressionMethod(COMPRESSION_DEFLATED);
> $zip->addDirectory( 'META-INF/' );
> # This on the other hand may fail.
> $zip->overwrite() == AZ_OK or error("Writing modified jar ($jar)
> failed$
>
> which I hope is an acceptable fix. Patch attached.
signature.asc
Description: OpenPGP digital signature
