Your message dated Thu, 05 Jan 2012 17:51:57 +0000
with message-id <e1rirtp-0005yk...@franck.debian.org>
and subject line Bug#653771: fixed in ntp 1:4.2.6.p3+dfsg-3
has caused the Debian Bug report #653771,
regarding FTBFS on kfreebsd-* due to -Wformat-security
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
653771: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653771
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: src:ntp
Version: 1:4.2.6.p3+dfsg-2
Severity: serious
Tags: patch
User: debian-...@lists.debian.org
Usertags: kfreebsd
Hi!
ntp is now failing to build on the kfreebsd-* arches. Some code is
failing the -Wformat-security build hardening test, and this is being
treated as an error during build. (I'm not sure why this is only the
case on kfreebsd?)
Anyway, I'm attaching a patch to fix the relevant code, which has
allowed me to finish building and then test ntpd on kfreebsd-i386.
Thanks!
Regards,
--
Steven Chamberlain
ste...@pyro.eu.org
Index: ntp-4.2.6.p3+dfsg/lib/isc/unix/ifiter_sysctl.c
===================================================================
--- ntp-4.2.6.p3+dfsg.orig/lib/isc/unix/ifiter_sysctl.c 2010-12-25 09:40:35.000000000 +0000
+++ ntp-4.2.6.p3+dfsg/lib/isc/unix/ifiter_sysctl.c 2011-12-30 20:30:25.000000000 +0000
@@ -272,10 +272,11 @@
return (ISC_R_SUCCESS);
} else {
- printf(isc_msgcat_get(isc_msgcat, ISC_MSGSET_IFITERSYSCTL,
- ISC_MSG_UNEXPECTEDTYPE,
- "warning: unexpected interface list "
- "message type\n"));
+ fprintf(stdout, "%s",
+ isc_msgcat_get(isc_msgcat, ISC_MSGSET_IFITERSYSCTL,
+ ISC_MSG_UNEXPECTEDTYPE,
+ "warning: unexpected interface list "
+ "message type\n"));
return (ISC_R_IGNORE);
}
}
Index: ntp-4.2.6.p3+dfsg/ntpd/ntp_config.c
===================================================================
--- ntp-4.2.6.p3+dfsg.orig/ntpd/ntp_config.c 2010-12-25 09:40:34.000000000 +0000
+++ ntp-4.2.6.p3+dfsg/ntpd/ntp_config.c 2011-12-30 20:38:45.000000000 +0000
@@ -2326,7 +2326,7 @@
if ((RES_MSSNTP & flags) && !warned_signd) {
warned_signd = 1;
fprintf(stderr, "%s\n", signd_warning);
- msyslog(LOG_WARNING, signd_warning);
+ msyslog(LOG_WARNING, "%s", signd_warning);
}
}
}
Index: ntp-4.2.6.p3+dfsg/ntpd/ntp_control.c
===================================================================
--- ntp-4.2.6.p3+dfsg.orig/ntpd/ntp_control.c 2010-12-25 09:40:36.000000000 +0000
+++ ntp-4.2.6.p3+dfsg/ntpd/ntp_control.c 2011-12-30 20:35:40.000000000 +0000
@@ -2948,7 +2948,7 @@
" %s", str);
}
NLOG(NLOG_SYSEVENT)
- msyslog(LOG_INFO, statstr);
+ msyslog(LOG_INFO, "%s", statstr);
} else {
/*
@@ -2980,7 +2980,7 @@
" %s", str);
}
NLOG(NLOG_PEEREVENT)
- msyslog(LOG_INFO, statstr);
+ msyslog(LOG_INFO, "%s", statstr);
}
record_proto_stats(statstr);
#if DEBUG
Index: ntp-4.2.6.p3+dfsg/ntpd/ntpd.c
===================================================================
--- ntp-4.2.6.p3+dfsg.orig/ntpd/ntpd.c 2011-12-30 20:58:45.000000000 +0000
+++ ntp-4.2.6.p3+dfsg/ntpd/ntpd.c 2011-12-30 20:39:39.000000000 +0000
@@ -1284,7 +1284,7 @@
msyslog(LOG_ERR, "%s:%d: fatal error:", file, line);
vsnprintf(errbuf, sizeof(errbuf), format, args);
- msyslog(LOG_ERR, errbuf);
+ msyslog(LOG_ERR, "%s", errbuf);
msyslog(LOG_ERR, "exiting (due to fatal error in library)");
abort();
@@ -1306,7 +1306,7 @@
msyslog(LOG_ERR, "%s:%d: unexpected error:", file, line);
vsnprintf(errbuf, sizeof(errbuf), format, args);
- msyslog(LOG_ERR, errbuf);
+ msyslog(LOG_ERR, "%s", errbuf);
if (++unexpected_error_cnt == MAX_UNEXPECTED_ERRORS)
{
Index: ntp-4.2.6.p3+dfsg/ntpd/refclock_oncore.c
===================================================================
--- ntp-4.2.6.p3+dfsg.orig/ntpd/refclock_oncore.c 2010-12-25 09:40:34.000000000 +0000
+++ ntp-4.2.6.p3+dfsg/ntpd/refclock_oncore.c 2011-12-30 20:37:33.000000000 +0000
@@ -4058,7 +4058,7 @@
snprintf(Msg, sizeof(Msg), "ONCORE[%d]: %s", instance->unit,
msg);
- syslog(log_level, Msg);
+ syslog(log_level, "%s", Msg);
i = strlen(msg);
--- End Message ---
--- Begin Message ---
Source: ntp
Source-Version: 1:4.2.6.p3+dfsg-3
We believe that the bug you reported is fixed in the latest version of
ntp, which is due to be installed in the Debian FTP archive:
ntp-doc_4.2.6.p3+dfsg-3_all.deb
to main/n/ntp/ntp-doc_4.2.6.p3+dfsg-3_all.deb
ntp_4.2.6.p3+dfsg-3.debian.tar.gz
to main/n/ntp/ntp_4.2.6.p3+dfsg-3.debian.tar.gz
ntp_4.2.6.p3+dfsg-3.dsc
to main/n/ntp/ntp_4.2.6.p3+dfsg-3.dsc
ntp_4.2.6.p3+dfsg-3_i386.deb
to main/n/ntp/ntp_4.2.6.p3+dfsg-3_i386.deb
ntpdate_4.2.6.p3+dfsg-3_i386.deb
to main/n/ntp/ntpdate_4.2.6.p3+dfsg-3_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 653...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Peter Eisentraut <pet...@debian.org> (supplier of updated ntp package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 05 Jan 2012 19:37:28 +0200
Source: ntp
Binary: ntp ntpdate ntp-doc
Architecture: source all i386
Version: 1:4.2.6.p3+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian NTP Team <pkg-ntp-maintain...@lists.alioth.debian.org>
Changed-By: Peter Eisentraut <pet...@debian.org>
Description:
ntp - Network Time Protocol daemon and utility programs
ntp-doc - Network Time Protocol documentation
ntpdate - client for setting system time from NTP servers
Closes: 653771
Changes:
ntp (1:4.2.6.p3+dfsg-3) unstable; urgency=medium
.
* Update format-security.patch to include kfreebsd-specific fixes
(closes: #653771)
Checksums-Sha1:
34b5468b26ce47424df93dfba252838e2c497955 1561 ntp_4.2.6.p3+dfsg-3.dsc
3b94cc53e6d1ac46ace1c252c9231d569e3891b3 559290
ntp_4.2.6.p3+dfsg-3.debian.tar.gz
532639dd5515f411431f3e1b69cc4dafa8d39d1d 1142494
ntp-doc_4.2.6.p3+dfsg-3_all.deb
11fc18d899462a3f7a02906888ff9a5442a1b866 515998 ntp_4.2.6.p3+dfsg-3_i386.deb
c1c42175c0323704f347afc5858b9533483c14dd 81378 ntpdate_4.2.6.p3+dfsg-3_i386.deb
Checksums-Sha256:
45ef231396b935df25d0871015256d8b076ba15c73455d4634beed321b564e25 1561
ntp_4.2.6.p3+dfsg-3.dsc
b625f812b320bfe505d999576d0f14e69479cf71981a98ba40f3f772f64274f7 559290
ntp_4.2.6.p3+dfsg-3.debian.tar.gz
d718772e3727924838d635eb87adef5fd3283df8212bcf92142d7a46932f6a28 1142494
ntp-doc_4.2.6.p3+dfsg-3_all.deb
af6e271124e0fcbaf0cb783a411f9c7592a1304d0479c693fa3634c8d34c7732 515998
ntp_4.2.6.p3+dfsg-3_i386.deb
8d65b56fb9a9199d0e7f3dd8d45d8d452c8514c5d1c58bef5910b80c257c2c25 81378
ntpdate_4.2.6.p3+dfsg-3_i386.deb
Files:
bc72fc8c5558a4e4d5568b4266400126 1561 net optional ntp_4.2.6.p3+dfsg-3.dsc
d3f55dc75c81758c44b74eb1c18070ed 559290 net optional
ntp_4.2.6.p3+dfsg-3.debian.tar.gz
e69518c36ee6c5c2e6a7278fd48abfc3 1142494 doc optional
ntp-doc_4.2.6.p3+dfsg-3_all.deb
28ae5d5f683f14914c3fe90ea35c8410 515998 net optional
ntp_4.2.6.p3+dfsg-3_i386.deb
7b9a311f71a5337b53168a54e2d82892 81378 net optional
ntpdate_4.2.6.p3+dfsg-3_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk8F4VwACgkQTTx8oVVPtMbXAgCgkc8cEW5+3fh1g31CEOLyZBrb
NKQAoLc49RRVTu3FTyU8W57HbheY+W11
=GAsn
-----END PGP SIGNATURE-----
--- End Message ---
