On Sat, Sep 24, 2011 at 08:36:27PM +0200, Mònica Ramírez Arceda wrote: >Source: jcal >Version: 0.4.0-1 >Severity: serious >Tags: wheezy sid >User: debian...@lists.debian.org >Usertags: qa-ftbfs-20110923 qa-ftbfs >Justification: FTBFS on amd64 > >Hi, > >During a rebuild of all packages in sid, your package failed to build on >amd64. > >Relevant part: >> debian/rules build >> dh_testdir >> # Add here commands to configure the package. >> ./autogen.sh -an >> -ne * checking for aclocal... >> -e yes >> -ne * checking for glibtoolize... >> -e no >> -ne * checking for libtoolize... >> -e yes >> -ne * checking for autoconf... >> -e yes >> -ne * checking for automake... >> -e yes >> -ne * checking for autoreconf... >> -e yes >> -e * done >> >> ./autogen.sh: 189: local: --copy: bad variable name >> -e using alternative method: manual >> make: *** [config.status] Error 2
More code in autogen.sh where bash will work, but not sh. Simple NMU patch here, upload in incoming shortly. Cheers, -- Steve McIntyre steve.mcint...@linaro.org <http://www.linaro.org/> Linaro.org | Open source software for ARM SoCs
diff -Nru jcal-0.4.0/debian/changelog jcal-0.4.0/debian/changelog --- jcal-0.4.0/debian/changelog 2011-07-29 12:23:51.000000000 +0000 +++ jcal-0.4.0/debian/changelog 2011-12-08 18:38:04.000000000 +0000 @@ -1,3 +1,11 @@ +jcal (0.4.0-1.1) unstable; urgency=low + + * NMU + * Quote parameters to perform() in autogen.sh. Closes: #642722. + Previous code would work in bash, but not sh. + + -- Steve McIntyre <steve.mcint...@linaro.org> Thu, 08 Dec 2011 17:54:45 +0000 + jcal (0.4.0-1) unstable; urgency=low * New upstream release. diff -Nru jcal-0.4.0/debian/patches/autogen-bashism.diff jcal-0.4.0/debian/patches/autogen-bashism.diff --- jcal-0.4.0/debian/patches/autogen-bashism.diff 2011-07-29 13:03:20.000000000 +0000 +++ jcal-0.4.0/debian/patches/autogen-bashism.diff 2011-12-08 18:26:31.000000000 +0000 @@ -1,7 +1,9 @@ Description: Fix autogen.sh to work in chroot envs Author: Lior Kaplan <kap...@debian.org> ---- a/autogen.sh -+++ b/autogen.sh +Index: jcal-0.4.0/autogen.sh +=================================================================== +--- jcal-0.4.0.orig/autogen.sh 2011-06-15 00:50:03.000000000 +0000 ++++ jcal-0.4.0/autogen.sh 2011-12-08 18:24:28.348438961 +0000 @@ -19,21 +19,21 @@ # along with libjalali. If not, see <http://www.gnu.org/licenses/>. # @@ -99,16 +101,21 @@ local STAT ACLOCAL="$(which aclocal 2>/dev/null)" is_present "${ACLOCAL}" "aclocal" 1 1 -@@ -182,7 +182,7 @@ +@@ -182,16 +182,16 @@ # $EXIT specifies whether perform() should exit on the event of # encoutering any errors or not. # $PARAMS are the parameters passed to the service. -function perform() { +- local SERVICE=$1 +- local NAME=$2 +- local EXIT=$3 +- local PARAMS=$4 +perform() { - local SERVICE=$1 - local NAME=$2 - local EXIT=$3 -@@ -191,7 +191,7 @@ ++ local SERVICE="$1" ++ local NAME="$2" ++ local EXIT="$3" ++ local PARAMS="$4" + local SSTAT echo -ne "${GREEN}*${RESET} running ${YELLOW}${NAME}${RESET} ${CYAN}${PARAMS}${RESET}... " ${SERVICE} ${PARAMS} >/dev/null 2>&1 diff -Nru jcal-0.4.0/debian/patches/jcal-manpage.diff jcal-0.4.0/debian/patches/jcal-manpage.diff --- jcal-0.4.0/debian/patches/jcal-manpage.diff 2011-07-28 21:42:37.000000000 +0000 +++ jcal-0.4.0/debian/patches/jcal-manpage.diff 2011-12-08 18:26:04.000000000 +0000 @@ -1,8 +1,10 @@ Description: Fix jcal man page Author: Lior Kaplan <kap...@debian.org> ---- a/man/jcal.1 -+++ b/man/jcal.1 -@@ -155,7 +155,6 @@ +Index: jcal-0.4.0/man/jcal.1 +=================================================================== +--- jcal-0.4.0.orig/man/jcal.1 2011-06-07 04:27:19.000000000 +0000 ++++ jcal-0.4.0/man/jcal.1 2011-12-08 18:21:03.000000000 +0000 +@@ -157,7 +157,6 @@ Written by Ashkan Ghassemi. <ghass...@ftml.net> .Sh REPORTING BUGS Report jcal bugs to <ghass...@ftml.net> @@ -10,7 +12,7 @@ libjalali home page: <http://savannah.nongnu.org/projects/jcal/> .Sh SEE ALSO .Nm jdate (1), -@@ -164,7 +163,6 @@ +@@ -166,7 +165,6 @@ .Nm jstrptime (3) .Sh COPYRIGHT Copyright (C) 2011 Ashkan Ghassemi.
