Hey,

may thanks for your feedback. It was my first python package to solve. 

> I hope you don't actually intend to upload this as NMU.
Not till now. I'll wait some days before I will trigger a minimal patch as 
NMU.

> cdbs didn't support dh_python2 until 0.4.90 (which is newer than the
> version in stable).
> Similarly, build-dependency on python should be bumped to 2.6.6-3~
> (though that's less important, as squeeze already has the required
> version).
Versionnumbers added.

> > XS-Python-Version: >= 2.6
> This should have been made X-Python-Version in the process of conversion
> to dh_python2. Also, XB-Python-Version should have been dropped.
Solved.

> >+clean::
> >+    rm -rf simplemediawiki.egg-info
> 
> Why? It's not mentioned in the changelog.
Moved to clean plus aditional info in changelog.

sandro

diff -Nru python-simplemediawiki-1.0.2/debian/changelog python-simplemediawiki-1.0.2/debian/changelog
--- python-simplemediawiki-1.0.2/debian/changelog	2011-02-13 02:58:52.000000000 +0100
+++ python-simplemediawiki-1.0.2/debian/changelog	2011-12-04 13:08:09.000000000 +0100
@@ -1,3 +1,14 @@
+python-simplemediawiki (1.0.2-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * using dh_python2 instead of dh_pysupport, to get requirements
+  * adding debian/clean for getting a realy clean environment for
+    for the .egg-info directory.
+  * Fix "python-simplemediawiki does not have proper dependencies"
+    using setuptools and install_requires (Closes: #645164)
+
+ -- Sandro Knauß <b...@sandroknauss.de>  Sat, 03 Dec 2011 15:42:02 +0100
+
 python-simplemediawiki (1.0.2-1) unstable; urgency=low
 
   * Initial release. (Closes: #613133)
diff -Nru python-simplemediawiki-1.0.2/debian/clean python-simplemediawiki-1.0.2/debian/clean
--- python-simplemediawiki-1.0.2/debian/clean	1970-01-01 01:00:00.000000000 +0100
+++ python-simplemediawiki-1.0.2/debian/clean	2011-12-04 13:00:54.000000000 +0100
@@ -0,0 +1 @@
+simplemediawiki.egg-info/*
diff -Nru python-simplemediawiki-1.0.2/debian/control python-simplemediawiki-1.0.2/debian/control
--- python-simplemediawiki-1.0.2/debian/control	2011-02-13 02:58:52.000000000 +0100
+++ python-simplemediawiki-1.0.2/debian/control	2011-12-04 13:46:36.000000000 +0100
@@ -2,16 +2,15 @@
 Section: python
 Priority: extra
 Maintainer: Benjamin Mako Hill <m...@debian.org>
-Build-Depends: cdbs, debhelper (>= 7.0.50~), python (>=2.6), python-support
+Build-Depends: cdbs (>= 0.4.90), debhelper (>= 7.0.50~), python (>=2.6.6-3~), python-setuptools, python-iso8601
 Standards-Version: 3.9.1
 Homepage: https://github.com/ianweller/python-simplemediawiki
-XS-Python-Version: >= 2.6
+X-Python-Version: >= 2.6
 
 Package: python-simplemediawiki
 Architecture: all
 Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}
 Provides: ${python:Provides}
-XB-Python-Version: ${python:Versions}
 Description: extremely low-level Python wrapper to the MediaWiki API
  SimpleMediawiki is an extremely low-level wrapper to the MediaWiki
  API. It automatically handles cookies and gzip compression so that
diff -Nru python-simplemediawiki-1.0.2/debian/patches/0007-using-setuptools.patch python-simplemediawiki-1.0.2/debian/patches/0007-using-setuptools.patch
--- python-simplemediawiki-1.0.2/debian/patches/0007-using-setuptools.patch	1970-01-01 01:00:00.000000000 +0100
+++ python-simplemediawiki-1.0.2/debian/patches/0007-using-setuptools.patch	2011-12-03 16:19:30.000000000 +0100
@@ -0,0 +1,32 @@
+From d4e3dfb996596208b8dfcd34bd519c5a425ea2e7 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Sandro=20Knau=C3=9F?= <b...@sandroknauss.de>
+Date: Sat, 3 Dec 2011 15:27:27 +0100
+Subject: [PATCH] using setuptools, if available
+
+---
+ setup.py |    7 +++++--
+ 1 files changed, 5 insertions(+), 2 deletions(-)
+
+diff --git a/setup.py b/setup.py
+index 316b91f..e2d3e3f 100644
+--- a/setup.py
++++ b/setup.py
+@@ -1,4 +1,8 @@
+-from distutils.core import setup
++try:
++    from setuptools import setup
++except ImportError:
++    from distutils.core import setup
++
+ setup(name='simplemediawiki',
+       version='1.0.2',
+       description='Extremely low-level wrapper to the MediaWiki API',
+@@ -11,7 +15,7 @@
+           'License :: OSI Approved :: GNU Library or Lesser General Public '
+           'License (LGPL)',
+       ],
+-      requires=[
++      install_requires=[
+           'iso8601',
+       ],
+       py_modules=['simplemediawiki'])
diff -Nru python-simplemediawiki-1.0.2/debian/patches/series python-simplemediawiki-1.0.2/debian/patches/series
--- python-simplemediawiki-1.0.2/debian/patches/series	2011-02-13 02:54:35.000000000 +0100
+++ python-simplemediawiki-1.0.2/debian/patches/series	2011-12-03 15:43:56.000000000 +0100
@@ -4,3 +4,4 @@
 0004-There-s-no-good-way-to-import-iso8601-apparently.patch
 0005-Add-docstring-to-_fetch_http.patch
 0006-Forget-about-version-checking-for-right-now.patch
+0007-using-setuptools.patch
diff -Nru python-simplemediawiki-1.0.2/debian/rules python-simplemediawiki-1.0.2/debian/rules
--- python-simplemediawiki-1.0.2/debian/rules	2011-02-12 20:12:07.000000000 +0100
+++ python-simplemediawiki-1.0.2/debian/rules	2011-12-04 13:04:12.000000000 +0100
@@ -1,7 +1,5 @@
 #!/usr/bin/make -f
 
-DEB_PYTHON_SYSTEM=pysupport
-
 include /usr/share/cdbs/1/rules/debhelper.mk
 #include /usr/share/cdbs/1/class/makefile.mk
 include /usr/share/cdbs/1/class/python-distutils.mk

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to