Your message dated Sat, 03 Dec 2011 22:47:36 +0000
with message-id <e1rwymq-00026z...@franck.debian.org>
and subject line Bug#649018: fixed in bist 0.5.1-4
has caused the Debian Bug report #649018,
regarding bist: FTBFS when building with -Werror=format-security
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
649018: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649018
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: bist
Version: 0.5.1-3
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu oneiric ubuntu-patch
Dear Maintainer,
bist appears to FTBFS on Ubuntu precise when build with the
-Werror=format-security parameter passed to GCC 4.6. [1]
This is because some fltk functions such as fl_warn, fl_choice, and others
expect a format string as first argument. However, in the case where the
format string stands by itself, -Werror=format-security will still require
one to pass format parameters to be interpolated: in this case, something
like NULL is sufficient.
The attached patch resolve this issue by adding NULLs as a final parameter
to the relevant fltk functions.
[1]
https://launchpadlibrarian.net/85118405/buildlog_ubuntu-precise-amd64.bist_0.5.1-3_FAILEDTOBUILD.txt.gz
Regards,
-- System Information:
Debian Release: wheezy/sid
APT prefers precise-updates
APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500,
'precise'), (100, 'precise-backports')
Architecture: amd64 (x86_64)
Kernel: Linux 3.1.0-2-generic (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages bist depends on:
ii libc6 2.13-20ubuntu5
ii libcairo2 1.10.2-6ubuntu3
ii libexpat1 2.0.1-7.2
ii libfltk1.1 1.1.10-8
ii libgcc1 1:4.6.2-2ubuntu1
ii libglib2.0-0 2.30.1-2ubuntu1
ii libncurses5 5.9-2
ii libpango1.0-0 1.29.4-2ubuntu1
ii libstdc++6 4.6.2-2ubuntu1
ii libtinfo5 5.9-2
ii libx11-6 2:1.4.4-4
ii libxpm4 1:3.5.9-4
bist recommends no packages.
bist suggests no packages.
-- no debconf information
From: Mathieu Trudel-Lapierre <mathieu.trudel-lapie...@canonical.com>
Subject: pass terminating NULLs to fl_ functions expecting formats.
Last-Update: 2011-11-16
Index: bist/src/util.cpp
===================================================================
--- bist.orig/src/util.cpp 2011-11-16 17:32:52.216281000 -0500
+++ bist/src/util.cpp 2011-11-16 17:36:32.684441611 -0500
@@ -1566,7 +1566,7 @@
string the_choice=string(_("File with name")) +
string(_(" ")) + string(the_file) + string(_(" ")) +
string(_("already exist.\nDo you want to overwrite it?"));
- return fl_choice(the_choice.c_str(),_("No"),_("Yes"),NULL);
+ return fl_choice(the_choice.c_str(),_("No"),_("Yes"),NULL,NULL);
}
Index: bist/src/immagine.cpp
===================================================================
--- bist.orig/src/immagine.cpp 2011-11-16 17:24:46.086009000 -0500
+++ bist/src/immagine.cpp 2011-11-16 17:39:48.280432894 -0500
@@ -2788,7 +2788,7 @@
warn += _warning[i] + "\n";
}
if(warn!=""){
- fl_alert(warn.c_str());
+ fl_alert(warn.c_str(),NULL);
}
}
void immagine::print_errors(){
@@ -2797,7 +2797,7 @@
errori+= _error[i] +"\n";
}
if(errori!=""){
- fl_alert(errori.c_str());
+ fl_alert(errori.c_str(),NULL);
}
}
@@ -6276,7 +6276,7 @@
can_write=1;
}else{
if(graphics){
- fl_message(strerror(errno));
+ fl_message(strerror(errno),NULL);
}else{
perror(NULL);
}
Index: bist/src/editor.cpp
===================================================================
--- bist.orig/src/editor.cpp 2011-11-16 17:24:46.086009000 -0500
+++ bist/src/editor.cpp 2011-11-16 17:41:08.872429299 -0500
@@ -394,7 +394,7 @@
void edit_nowar_cb(Fl_Widget* w, void* v){
const static char* man="Copyright (C) 2005 Valerio Benfante.\nThis is free software; see the file COPYING for copying conditions.\nThere is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\nThe logo is copyright (C) 2005 Luisa Russo and is released under GNU GPL";
- fl_message(man);
+ fl_message(man, NULL);
}
--- End Message ---
--- Begin Message ---
Source: bist
Source-Version: 0.5.1-4
We believe that the bug you reported is fixed in the latest version of
bist, which is due to be installed in the Debian FTP archive:
bist_0.5.1-4.debian.tar.gz
to main/b/bist/bist_0.5.1-4.debian.tar.gz
bist_0.5.1-4.dsc
to main/b/bist/bist_0.5.1-4.dsc
bist_0.5.1-4_i386.deb
to main/b/bist/bist_0.5.1-4_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 649...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
David Paleino <da...@debian.org> (supplier of updated bist package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 03 Dec 2011 23:24:58 +0100
Source: bist
Binary: bist
Architecture: source i386
Version: 0.5.1-4
Distribution: unstable
Urgency: low
Maintainer: David Paleino <da...@debian.org>
Changed-By: David Paleino <da...@debian.org>
Description:
bist - chemical drawing tool
Closes: 649018
Changes:
bist (0.5.1-4) unstable; urgency=low
.
* Fix FTBFS with gcc 4.6, thanks to Mathieu Trudel-Lapierre
(Closes: #649018)
Checksums-Sha1:
f3d9b5a6e3c47e741e89f9ded42343f95e218a0f 1286 bist_0.5.1-4.dsc
947f3181307b20104c1cee5b83b8d0bfd918e2c1 10876 bist_0.5.1-4.debian.tar.gz
fe8924e5da3fb14fa9370860b8e1bfd51be61b7b 772960 bist_0.5.1-4_i386.deb
Checksums-Sha256:
841afbf852cb1aef67f3223b25d44d1af86c2f139df1f9a09e404a45af6c4cce 1286
bist_0.5.1-4.dsc
937f9595add3d452ce3aec662b142f4fad6123cfc3ad6aecac42bf6a9a89e987 10876
bist_0.5.1-4.debian.tar.gz
fd7cf7a41d07c7bfd1479d6569cb2c384a1979a627a0c1181b8fefd3c6d7c4df 772960
bist_0.5.1-4_i386.deb
Files:
0828c4d7f8a6e6f758933f1ef7fd68e5 1286 science optional bist_0.5.1-4.dsc
b9a91a1e07cc47a25486b00fa9e4ad56 10876 science optional
bist_0.5.1-4.debian.tar.gz
5d8ae22779549c09faddcdcf9dd97fde 772960 science optional bist_0.5.1-4_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEUEARECAAYFAk7aoqgACgkQ5qqQFxOSsXSEWQCYozBbMYbqup3J2IOlJBOtsPJf
qwCgjDIJLQQJp1VNx1hnYNPyokDHZbA=
=f6EM
-----END PGP SIGNATURE-----
--- End Message ---
