Tanguy Ortolo, 2011-11-10 23:53 UTC+0100: > I imagine that the conditional increment is meant to include the last > incomplete frame in the case where a track does not exactly end on a > frame. The current implementation is wrong, and it could be corrected by > conditionally incrementing len *before* we start computing anything from > it; however, given that a frame is only one 75th a second, I think it > would be better to simply remove the conditional increment: part of a > frame could be lost on the very last track of the disk but I do not > think it would matter to anyone.
Sorry for the this lot of messages, but that was not exact. I have just read more about the CUE format and what Brasero does; in fact the possible shift would only affect the position of the beginning of each track. When the total length before a given track does not end exactly on a frame it has to be rounded in some way. The current, buggy behaviour of Brasero is to round it to the frame above; the one I am proposing it to round it to the one below; the most accurate one would be to round it to the closest one. But as we are talking about 1/75th of seconds, I still think the simplest solution would be the best one: truncating it to the frame below. -- ,--. : /` ) Tanguy Ortolo <xmpp:tan...@ortolo.eu> <irc://irc.oftc.net/Elessar> | `-' Debian Maintainer \_
signature.asc
Description: Digital signature
