tags 594283 + patch
thanks

Le mercredi, 25 août 2010 07.58:59, Matthias Klose a écrit :
> This package builds with a non standard compiler version; please check
> if this package can be built with the default version of gcc/g++.
> 
> Please keep this report open until the package uses the default
> compiler version for the package build.

Hi dear Grub maintainers, 

I just tried to _build_ Grub (Legacy) with the currently default GCC, and 
(without much surprise), it builds fine (at least on amd64).

A possible proposed NMU is attached (basically removing the explicit 
references to gcc-4.3 and Build-Depending on gcc-multilib [amd64]), but I 
can't be confident enough to upload it without having tested it.

So, Grub maintainers, what do you want to do? As this RC bug shows, Grub 
Legacy currently doesn't build from source; so there are probably two 
solutions only:

a) Build it with the default compiler, get it tested and migrated to testing,
b) remove it from Debian (is grub-pc ready enough [I use it for a very long 
time, but I don't have special needs…] ?)

What's your opinion ?

Cheers,

-- 
OdyX
diff -u grub-0.97/debian/changelog grub-0.97/debian/changelog
--- grub-0.97/debian/changelog
+++ grub-0.97/debian/changelog
@@ -1,3 +1,10 @@
+grub (0.97-65.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Build with the default gcc (Closes: #594283).
+
+ -- Didier Raboud <o...@debian.org>  Mon, 14 Nov 2011 22:15:14 +0100
+
 grub (0.97-65) unstable; urgency=low
 
   * Fix grub/migrate_from_legacy title to not end with a full stop.
diff -u grub-0.97/debian/rules grub-0.97/debian/rules
--- grub-0.97/debian/rules
+++ grub-0.97/debian/rules
@@ -54,10 +54,6 @@
   LDFLAGS=-static
 endif
 
-# We didn't test GRUB Legacy with GCC 4.4, and it's not worth
-# the risk since it's being replaced by GRUB 2.
-CC=gcc-4.3
-
 patch:
 	dh_quilt_patch
 
@@ -70,7 +66,7 @@
 
 	# Add here commands to configure the package.
 	aclocal-1.9 && automake-1.9 && autoconf
-	CC=$(CC) LDFLAGS=$(LDFLAGS) ./configure \
+	LDFLAGS=$(LDFLAGS) ./configure \
 		--host=$(DEB_HOST_GNU_TYPE) \
 		--build=$(DEB_BUILD_GNU_TYPE) \
 		--prefix=/usr \
diff -u grub-0.97/debian/control grub-0.97/debian/control
--- grub-0.97/debian/control
+++ grub-0.97/debian/control
@@ -12,8 +12,7 @@
  texinfo,
  libncurses5-dev | libncurses-dev,
  lib32ncurses5-dev [amd64],
- gcc-4.3,
- gcc-4.3-multilib [amd64]
+ gcc-multilib [amd64]
 Build-Depends-Indep: texi2html
 Standards-Version: 3.8.3
 Vcs-Svn: svn://svn.debian.org/svn/pkg-grub/grub/

Reply via email to