This bug has been fixed upstream in e1c5e8b8d14; attached is a patch
suitable for quilt.


Regards,

        Fred
Description: Don't pass strings to be printed in format string parameter.
 This patch has been stolen from git (e1c5e8b8d14575d0b0152b2effc1b790538eb1b5)
Author: Patric Theune <patric.the...@gmail.com>.
Bug-Debian: http://bugs.debian.org/643458

Index: planner-0.14.4/libplanner/mrp-storage-module-factory.c
===================================================================
--- planner-0.14.4.orig/libplanner/mrp-storage-module-factory.c 2011-10-01 
15:02:03.656426278 +0200
+++ planner-0.14.4/libplanner/mrp-storage-module-factory.c      2011-10-01 
15:04:24.081122614 +0200
@@ -90,7 +90,7 @@
        
        factory->library = g_module_open (factory->name, 0);
        if (!factory->library) {
-               g_warning (g_module_error ());
+               g_warning ("%s", g_module_error ());
                return FALSE;
        }
   
@@ -98,7 +98,7 @@
        if (!g_module_symbol (factory->library, "module_init", 
(gpointer)&factory->init) ||
            !g_module_symbol (factory->library, "module_new", 
(gpointer)&factory->new) ||
            !g_module_symbol (factory->library, "module_exit", 
(gpointer)&factory->exit)) {
-               g_warning (g_module_error ());
+               g_warning ("%s", g_module_error ());
                g_module_close (factory->library);
                
                return FALSE;
Index: planner-0.14.4/libplanner/mrp-task.c
===================================================================
--- planner-0.14.4.orig/libplanner/mrp-task.c   2011-10-01 15:05:00.457302957 
+0200
+++ planner-0.14.4/libplanner/mrp-task.c        2011-10-01 15:05:06.613333556 
+0200
@@ -1086,6 +1086,7 @@
                g_set_error (error,
                             MRP_ERROR,
                             MRP_ERROR_TASK_RELATION_FAILED,
+                            "%s",
                             tmp);
                
                return NULL;
@@ -1104,6 +1105,7 @@
                g_set_error (error,
                             MRP_ERROR,
                             MRP_ERROR_TASK_RELATION_FAILED,
+                            "%s",
                             tmp);
                
                return NULL;
Index: planner-0.14.4/src/planner-window.c
===================================================================
--- planner-0.14.4.orig/src/planner-window.c    2008-08-03 18:23:34.000000000 
+0200
+++ planner-0.14.4/src/planner-window.c 2011-10-01 15:06:00.637601403 +0200
@@ -1479,6 +1479,7 @@
                                                                 
GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
                                                                 
GTK_MESSAGE_WARNING,
                                                                 
GTK_BUTTONS_YES_NO,
+                                                                "%s",
                                                                 
error->message);
                                
                                response = gtk_dialog_run (GTK_DIALOG (dialog));
@@ -1495,6 +1496,7 @@
                                                         GTK_DIALOG_MODAL | 
GTK_DIALOG_DESTROY_WITH_PARENT,
                                                         GTK_MESSAGE_ERROR,
                                                         GTK_BUTTONS_OK,
+                                                        "%s",
                                                         error->message);
                        
                        gtk_dialog_run (GTK_DIALOG (dialog));
@@ -1594,6 +1596,7 @@
                                                         GTK_DIALOG_MODAL | 
GTK_DIALOG_DESTROY_WITH_PARENT,
                                                         GTK_MESSAGE_ERROR,
                                                         GTK_BUTTONS_OK,
+                                                        "%s",
                                                         error->message);
                        gtk_dialog_run (GTK_DIALOG (dialog));
                        gtk_widget_destroy (dialog);
@@ -1699,6 +1702,7 @@
                        GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
                        GTK_MESSAGE_ERROR,
                        GTK_BUTTONS_OK,
+                       "%s",
                        error->message);
                gtk_dialog_run (GTK_DIALOG (dialog));
                gtk_widget_destroy (dialog);

Reply via email to