Bug#636001: clementine: FTBFS in qFuzzyCompare on armel, armhf and sh4

[Nobuhiro Iwamatsu]

Package: clementine
Version: 0.7.1+dfsg-2
Justification: ftbfs
Severity: serious
Tags: patch

Hi,

clementine FTBFS on armel, armfg and sh4.

- armel
  
https://buildd.debian.org/status/fetch.php?pkg=clementine&arch=armel&ver=0.7.1%2Bdfsg-2&stamp=1311217925
- armhf
  
http://buildd.debian-ports.org/status/fetch.php?pkg=clementine&arch=armhf&ver=0.7.1%2Bdfsg-2&stamp=1311341981
- sh4
  
http://buildd.debian-ports.org/status/fetch.php?pkg=clementine&arch=sh4&ver=0.7.1%2Bdfsg-2&stamp=1311283442

----
/build/buildd-clementine_0.7.1+dfsg-2-armel-Txwhgu/clementine-0.7.1+dfsg/src/widgets/nowplayingwidget.cpp:344:49:
error: ISO C++ says that these are ambiguous, even though the worst
conversion for the first is better than the worst conversion for the
second: [-Werror]
/usr/include/qt4/QtCore/qglobal.h:1893:20: note: candidate 1: bool
qFuzzyCompare(double, double)
/usr/include/qt4/QtCore/qglobal.h:1898:20: note: candidate 2: bool
qFuzzyCompare(float, float)
cc1plus: all warnings being treated as errors
----

I created a patch which revise this problem.
Could you check and apply this patch?

Best regards,
  Nobuhiro

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.39-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash


-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

diff --git a/debian/changelog b/debian/changelog
index 7f5be63..6129e55 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+clementine (0.7.1+dfsg-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix FTBFS by qFuzzyCompare function on armel, armhf and sh4.
+
+ -- Nobuhiro Iwamatsu <iwama...@debian.org>  Sat, 30 Jul 2011 03:53:04 +0900
+
 clementine (0.7.1+dfsg-2) unstable; urgency=low
 
   [ Thomas Pierson ]
diff --git a/src/widgets/nowplayingwidget.cpp b/src/widgets/nowplayingwidget.cpp
index 92c8877..ef92458 100644
--- a/src/widgets/nowplayingwidget.cpp
+++ b/src/widgets/nowplayingwidget.cpp
@@ -341,7 +341,7 @@ void NowPlayingWidget::DrawContents(QPainter *p) {
 
 void NowPlayingWidget::FadePreviousTrack(qreal value) {
   previous_track_opacity_ = value;
-  if (qFuzzyCompare(previous_track_opacity_, 0.0)) {
+  if (qFuzzyCompare(previous_track_opacity_, qreal(0.0))) {
     previous_track_ = QPixmap();
   }