clone 616291 -1
retitle -1 axis2c: please do not use -Werror
tags -1 =
reassign -1 src:axis2c 1.6.0-2
severity -1 wishlist
quit

Matej Vela wrote:

> The reason is that OpenSSL 1.0.0 adds a const qualifier for the return
> value of SSLv23_method().  I think it's simpler to just fix the warning,
> as upstream did here:
>
>     <http://svn.apache.org/viewvc?view=revision&revision=918422>
>
> Working patch attached.

Thanks!  Maybe the following would be simpler.

-- >8 -- cut here -- >8 --
--- a/src/core/transport/http/sender/ssl/ssl_utils.c
+++ b/src/core/transport/http/sender/ssl/ssl_utils.c
@@ -41,7 +41,7 @@ axis2_ssl_utils_initialize_ctx(
     axis2_char_t * key_file,
     axis2_char_t * ssl_pp)
 {
-    SSL_METHOD *meth = NULL;
+    const SSL_METHOD *meth = NULL;
     SSL_CTX *ctx = NULL;
     axis2_char_t *ca_file = server_cert;
 
-- 8< -- cut here -- 8< --

I think fixing this is a good idea at any rate, but it would also be
nice to avoid -Werror to simplify the work of the release team and
other people who might want to be able to build with a new toolchain
(or on an unfamiliar platform) without worrying about warnings as of
yet unfixed.  Unfortunately there is no automated way to grab warning
messages from build logs yet (though gcc-4.6's error messages with
[-Wwhatever] should make it a lot easier), so I can't say there is a
better way. :/

So I'm cloning as a wishlist bug.  The patch I sent also implements
support for DEB_CFLAGS_APPEND; if possible, I'd like to see that bit
incorporated some time even if you keep -Werror :) (but I'm not
bothering to file a bug for that).

Thank you for your thoughtfulness.

Regards,
Jonathan



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to