Package: rhythmbox-applet Version: 0.1.7-1 Severity: serious Tags: patch rhythmbox-applet fails to build because it is missing a sentinel in a function call:
> if cc -DHAVE_CONFIG_H -I. -I. -I.. > -DPKG_DATA_DIR=\"/usr/share/rhythmbox-applet/\" -DDATA_DIR=\"/usr/share/\" > -DGNOMELOCALEDIR=\""/usr/share/locale"\" -Wall -W -Wno-unused -Werror -g > -DXTHREADS -DORBIT2=1 -pthread -I/usr/include/panel-2.0 > -I/usr/include/gtk-2.0 -I/usr/include/libgnomeui-2.0 > -I/usr/include/libbonoboui-2.0 -I/usr/lib/gtk-2.0/include > -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 > -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include > -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 > -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 > -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 > -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 > -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/eel-2 > -I/usr/include/gail-1.0 -MT rb-applet.o -MD -MP -MF ".deps/rb-applet.Tpo" \ > -c -o rb-applet.o `test -f 'rb-applet.c' || echo './'`rb-applet.c; \ > then mv -f ".deps/rb-applet.Tpo" ".deps/rb-applet.Po"; \ > else rm -f ".deps/rb-applet.Tpo"; exit 1; \ > fi > cc1: warnings being treated as errors > rb-applet.c: In function 'show_rating_toggled_cb': > rb-applet.c:530: warning: missing sentinel in function call The attached patch fixes this problem. -- Matt
only in patch2:
unchanged:
--- rhythmbox-applet-0.1.7.orig/src/rb-applet.c
+++ rhythmbox-applet-0.1.7/src/rb-applet.c
@@ -527,7 +527,7 @@
{
gboolean show_it = gtk_toggle_button_get_active (button);
- g_object_set (data->rating, "visible", show_it, FALSE);
+ g_object_set (data->rating, "visible", show_it, NULL);
panel_applet_gconf_set_bool (PANEL_APPLET (data->applet),
"show_rating", show_it,
NULL);
signature.asc
Description: Digital signature
