Hi, Mike.
2011/1/29 Mike Hommey <m...@glandium.org>:
> On Sat, Jan 29, 2011 at 05:36:38PM +0900, Nobuhiro Iwamatsu wrote:
>> Hi,
>>
>> > | /usr/include/xulrunner-1.9.1/unstable/nscore.h:406:2: warning: #warning
>> > libxul SDK was configured with char16_t support, but now building without
>> > | In file included from
>> > /usr/include/xulrunner-1.9.1/unstable/nsStringGlue.h:52,
>> > | from
>> > /usr/include/xulrunner-1.9.1/unstable/nsNetUtil.h:46,
>> > | from style_sheets.cpp:12:
>> > | /usr/include/xulrunner-1.9.1/unstable/nsStringAPI.h:1066:4: warning:
>> > #warning Using conversions for literal strings. Please consider using
>> > 2-bytes wchar_t or char16_t instead
>> > | In file included from style_sheets.cpp:12:
>> > | /usr/include/xulrunner-1.9.1/unstable/nsNetUtil.h: In function 'nsresult
>> > NS_MakeRandomInvalidURLString(nsCString_external&)':
>> > | /usr/include/xulrunner-1.9.1/unstable/nsNetUtil.h:1649: error: 'struct
>> > nsID' has no member named 'ToProvidedString'
>> > | make[1]: *** [.objs/style_sheets.o] Error 1
>> > | make[1]: Leaving directory
>> > `/build/sbuild-videolink_1.2.9-2-i386-n2SWQL/videolink-1.2.9'
>> > | make: *** [build] Error 2
>>
>> I easily checked this.
>> I think that this is bug of xulrunner-1.9.1.
>> Because If it was defined XPCOM_GLUE_AVOID_NSPR, user can not use
>> ToProvidedString().
>>
>> And XPCOM_GLUE_AVOID_NSPR was defined if "defined(XPCOM_GLUE) &&
>> !defined(XPCOM_GLUE_USE_NSPR).
>>
>> from usr/include/xulrunner-1.9.1/unstable/nsID.h
>> 97 #ifndef XPCOM_GLUE_AVOID_NSPR
>> 98 /**
>> 99 * nsID string encoder. Returns an allocated string in
>> 100 * {xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx} format. Caller should
>> free string.
>> 101 * YOU SHOULD ONLY USE THIS IF YOU CANNOT USE ToProvidedString() BELOW.
>> 102 */
>> 103 NS_COM_GLUE char* ToString() const;
>> 104
>> 105 /**
>> 106 * nsID string encoder. Builds a string in
>> 107 * {xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx} format, into a
>> char[NSID_LENGTH]
>> 108 * buffer provided by the caller (for instance, on the stack).
>> 109 */
>> 110 NS_COM_GLUE void ToProvidedString(char (&dest)[NSID_LENGTH]) const;
>> 111
>> 112 #endif // XPCOM_GLUE_AVOID_NSPR
>>
>>
>> But However, NS_MakeRandomInvalidURLString() does not seem to support this.
>> # NS_MakeRandomInvalidURLString is in
>> /usr/include/xulrunner-1.9.1/unstable/nsNetUtil.h"
>>
>> Mike, how do you think?
>
> I think that if videolink needs this function, it should define
> XPCOM_GLUE_USE_NSPR, and probably link against nspr.
>
Oh, Sorry and thanks for your comment.
We lacked defined of the XPCOM_GLUE_USE_NSPRB.
I attached the patch which revised this problem.
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
diff --git a/Makefile b/Makefile
index b9b794e..c250490 100644
--- a/Makefile
+++ b/Makefile
@@ -8,9 +8,9 @@ mandir := $(sharedir)/man
ifeq ($(shell pkg-config --atleast-version 1.9 mozilla-gtkmozembed-embedding && echo yes),yes)
moz_name := xulrunner-1.9
moz_pc := mozilla-gtkmozembed-embedding
- moz_cppflags_extra := $(shell pkg-config --cflags xulrunner-nspr)
+ moz_cppflags_extra := $(shell pkg-config --cflags xulrunner-nspr) -DXPCOM_GLUE_USE_NSPR
moz_unstable_cppflags_extra :=
- moz_ldflags_extra :=
+ moz_ldflags_extra := $(shell pkg-config --libs xulrunner-nspr)
else
ifeq ($(shell pkg-config --exists xulrunner-gtkmozembed && echo yes),yes)
moz_name := xulrunner
