On Mon, Jan 24, 2011 at 10:40:06PM +0200, Teodor MICU wrote: > 2011/1/24 Harald Jenny <har...@a-little-linux-box.at>: > > On Mon, Jan 24, 2011 at 08:59:41PM +0200, Teodor MICU wrote: > >> 2011/1/24 Harald Jenny <har...@a-little-linux-box.at>: > >> > Ok although the PIDFILE line can be removed with the below code. > >> > >> I'm don't see where PIDFILE is removed. > > > > Just take a look at the next patch version. > > I can only spot some cosmetic issues, otherwise I see no problem. The > change USER -> SYSTEMUSER only makes the diff larger and not really > necessary.
I tend to disagree as USER (as well as USERNAME) is set by the shell and so a [ -n "$USER" ] || USER=amavis check always evaluates to the user running the init script :-/ - as this is not the desired action I decided to rename USER to SYSTEMUSER (and will also change this in the config file). > It was a good idea to get the 'dirname' out on their own, it is > cleaner like this. Thanks :-) > > >> I was wrong here. MILTERSOCKET can be empty in the config from > >> /etc/default/$NAME and this should be the default. > > > > Yes but if it's empty the default value is a unix socket. > > Ok. The default value for the binary is defined when doing ./configure > > >> I think the above test is always false if you correctly initialize > >> MILTERSOCKET after the /etc/default/$NAME has been sourced. > >> [ -z "$MILTERSOCKET" ] || > >> MILTERSOCKET="/var/lib/amavis/amavisd-milter.sock" > > > > True but I only want to append to OPTIONS when the default values are > > overriden because this keeps the command line shorter :-). > > Ok, I see how MILTERSOCKET is used now. IMHO it's better to keep the number of command line options as short as possible. > > >> Later on you don't check if it's empty but only the type: unix vs inet. > > > > Well seems to me this is just a change in the code flow... > > Yes. Ok > > The release team will check too, maybe we missed something. :) Well I don't think this package will make it into Debian Squeeze as for me a prerequisite is a fixed libmilter version... sorry when I kept you from doing other more release-critical work, this was not my intention :-(. > > Thanks > Bye and good night Harald -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
