Hi Jean-Baptiste!

* Jean-Baptiste Lallement <jeanbaptiste.lallem...@gmail.com> [100427 00:24]:

> In Ubuntu, we've applied the attached patch to achieve the following:
> 
>   * debian/postrm: don't fail if canna user is already deleted (LP: #569678)
> 
> We thought you might be interested in doing the same. 

While I'm not the maintainer of the package, but just a fellow DD who
looked through the list of release critical bugs, I like to comment on
the proposed patch:

-    deluser --remove-home canna
+    deluser --remove-home canna >/dev/null 2>&1 || true

Sorry, but that is a quite ugly solution.  Ignoring *all* errors deluser
might show?  And then even hiding all information from the user?  What
if deluser fails for an other reason?

A better solution would be to check the return value of deluser (it
sends a sepperate exit code, if the user didn't exists) or simple
checking the existence of the user before trying to remove it.


Best solution woudl of course to check why the postrm script is called
twice, but just hiding all errors is nice bike shedding, but not a
propper fix.


Best Regards,
  Alexander, who just uploaded a "check existence before removing" fix




-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to