-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
Has any progress been made with this bug?
After reviewing the patch patch/malloc.patch, it's clear this is
introducing K&Risms which GCC 4.0 won't allow. These need replacing
with proper prototypes or, preferably, include a header containing the
prototypes. It's not at all clear that the patch is actually
necessary or desirable given that all it does is wrap the system
malloc() and related functions.
Summary:
1) The patch is written using K&R C. It's 2005, not 1985, and this is
no longer acceptable.
2) The patch is funtamentally broken. Have you looked at it closely?
Example:
+char *
+malloc0(size)
+int size;
+{
+ if(size == NULL){
+ size = 1;
"size" is an integer, not a pointer, so a comparison to NULL is
broken...
3) There is no header for the new functions.
4) Modules should not prototype functions from other modules, they
should use the header. K&R prototypes are even worse!
Have any attempts been made with upstream to completely ANSI-ify the
source? There are workarounds for SVR2 in there, and that's well
obsolete. We have had ANSI/ISO C for over 16 years now.
Regards,
Roger
- --
Roger Leigh
Printing on GNU/Linux? http://gimp-print.sourceforge.net/
Debian GNU/Linux http://www.debian.org/
GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>
iD8DBQFDGx6BVcFcaSW/uEgRAp/yAJ9zImnPVO7oCovkP903zwJNulMEaQCg5zfD
BAbQc0apx5QEnlUeXYqAIfg=
=1VnW
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
