tag 584344 - unreproducible thanks On Sun, Aug 15, 2010 at 09:05:21PM +0200, Lucas Nussbaum wrote: > On 15/08/10 at 21:45 +0300, Niko Tyni wrote:
> > My best guess is that it's somehow related to bigger pipe buffers on > > systems with more memory than mine or something like that, but I can't > > see the problem in the code no matter how much I glare at it. > > > > Possibly just growing the buffers in speedy/t/detach.t would help, > > but it would be nice to actually understand why. This would seem to be the case. The attached patch makes it work again. I doubt there's anything wrong with the actual code, only with the test assumptions of what makes a buffer 'large'. The system where this is reproducible has 16 GB RAM and 300 GB swap, which is quite a bit more than anywhere else where I tried this. I've now got strace output to compare, and I'll try to gain a better understanding of the problem before uploading a fixed package. > (credentials sent in a private mail) Thanks! I'm done for now, will ask again if I need another go. -- Niko Tyni nt...@debian.org
diff --git a/speedy/t/detach.t b/speedy/t/detach.t index 3154919..8427347 100644 --- a/speedy/t/detach.t +++ b/speedy/t/detach.t @@ -8,7 +8,7 @@ use strict; use IO::File; my $smbuf = 8 * 1024; -my $lgbuf = 512 * 1024; +my $lgbuf = 51200 * 1024; my $scr = 't/scripts/detach'; use vars qw(@open_files @pids %children); diff --git a/speedy/t/scripts/detach b/speedy/t/scripts/detach index 57d1029..72f35f8 100644 --- a/speedy/t/scripts/detach +++ b/speedy/t/scripts/detach @@ -1,3 +1,3 @@ $| = 1; print "$$\n"; -print 'x' x (500*1024); +print 'x' x (50000*1024);