Source: chatplus
Version: 0.1-1
Severity: serious
Justification: Debian Policy 3.5, Python Policy 3.1.1
Tags: patch

chatplus builds private Python extensions. Such extensions are normally not binary compatible across different Python versions, so the package must declare tight dependency on the version for which the extensions was built.

The attached patches fix the following things:

1. Prevents Python extension modules from being linked with libpythonX.Y (which is not needed and potentially harmful), so that python-support can recognize them.

2. Passes /usr/share/chatplus/ to dh_pysupport, so that python-support is able to find modules shipped by chatplus-server.

3. Lets dh_pysupport automatically generate proper dependencies on python on python-support.

--
Jakub Wilk
--- chatplus-0.1.orig/Makefile
+++ chatplus-0.1/Makefile
@@ -2,7 +2,7 @@
 PYTHON ?= python
 PYTHONVER = `$(PYTHON) -c 'import sys; print sys.version[:3]'`
 CFLAGS = `pkg-config --cflags gtk+-2.0 pygtk-2.0` -fPIC -I/usr/include/python$(PYTHONVER) -I.
-LDFLAGS = `pkg-config --libs gtk+-2.0 pygtk-2.0` -lpython$(PYTHONVER)
+LDFLAGS = `pkg-config --libs gtk+-2.0 pygtk-2.0`
 
 all: trayicon.so
 
diff -u chatplus-0.1/debian/rules chatplus-0.1/debian/rules
--- chatplus-0.1/debian/rules
+++ chatplus-0.1/debian/rules
@@ -83,7 +83,7 @@
 	dh_testroot
 	dh_installchangelogs 
 	dh_installdocs
-	dh_pysupport
+	dh_pysupport /usr/share/chatplus/
 	dh_installman
 	dh_link
 	dh_strip
diff -u chatplus-0.1/debian/control chatplus-0.1/debian/control
--- chatplus-0.1/debian/control
+++ chatplus-0.1/debian/control
@@ -7,7 +7,7 @@
 
 Package: chatplus
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, python, python-glade2
+Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}, python-glade2
 Suggests: chatplus-server
 Description: a simple graphical LAN chat programme with unicode
  Chat+ is a simple python-based LAN chat program with unicode support. It
@@ -19,7 +19,7 @@
 
 Package: chatplus-server
 Architecture: all
-Depends: ${shlibs:Depends}, ${misc:Depends}, python
+Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}
 Suggests: chatplus
 Description: a simple LAN chat programme with unicode (server)
  Chat+ is a simple python-based LAN chat program with unicode support. It

Attachment: signature.asc
Description: Digital signature

Reply via email to