Your message dated Sun, 01 Aug 2010 16:47:07 +0000 with message-id <e1ofbgp-00081s...@franck.debian.org> and subject line Bug#589708: fixed in guilt 0.33-2 has caused the Debian Bug report #589708, regarding guilt: undeclared dependency on git (<< 1:1.8) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 589708: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=589708 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: guilt Version: 0.33-1 Severity: serious Justification: policy §3.5 Tags: patch Hi Iulian, :) guilt has some code that in my opinion should be patched out in Debian: | case "$gitver" in | 1.5.*) ;; # git config | 1.6.*) ;; # git config | 1.7.*) ;; # git config | *) die "Unsupported version of git ($gitver)" ;; | esac The problem with this code is that it goes behind the package manager’s back and makes the code obsolete before it really should be. Because previous versions of guilt would error out when run with git 1.7.x, now git is going to need to Breaks: old versions of guilt. Which imposes a constraint during upgrades: guilt has to be deconfigured before git is upgraded. That’s even in cases like Bug#576937 where the only incompatibility between guilt and new git was that created by this check! Now _upstream_ such a check makes sense because some people are installing guilt without a package manager. So I think we should patch it out for Debian, and handle backward incompatibilities by adding Breaks: to git where necessary. However, that is not what this patch is about. This patch just gets dependencies correct for the current situation, where guilt is going to break itself once git 1.8 comes out... we might as well declare it. Thoughts welcome, as always. Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> --- diff --git a/debian/changelog b/debian/changelog index d254d54..3bc446f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +guilt (0.33-2) UNRELEASED; urgency=low + + * Depends: git (<< 1:1.8). + + -- Jonathan Nieder <jrnie...@gmail.com> Tue, 20 Jul 2010 02:25:11 -0500 + guilt (0.33-1) unstable; urgency=low * New upstream release. diff --git a/debian/control b/debian/control index 598edfb..112d4e7 100644 --- a/debian/control +++ b/debian/control @@ -12,7 +12,8 @@ Vcs-Git: git://git.debian.org/git/collab-maint/guilt.git Package: guilt Architecture: all -Depends: ${misc:Depends}, git-core (>= 1.4) +Depends: ${misc:Depends}, git-core (>= 1.4) | git (>= 1:1.7), + git-core (<= 1:1.7.0.4-1) | git (<< 1:1.8) Description: quilt for git; similar to Mercurial queues Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. The one distinguishing --
--- End Message ---
--- Begin Message ---Source: guilt Source-Version: 0.33-2 We believe that the bug you reported is fixed in the latest version of guilt, which is due to be installed in the Debian FTP archive: guilt_0.33-2.diff.gz to main/g/guilt/guilt_0.33-2.diff.gz guilt_0.33-2.dsc to main/g/guilt/guilt_0.33-2.dsc guilt_0.33-2_all.deb to main/g/guilt/guilt_0.33-2_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 589...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Iulian Udrea <iul...@ubuntu.com> (supplier of updated guilt package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Sun, 01 Aug 2010 15:32:06 +0100 Source: guilt Binary: guilt Architecture: source all Version: 0.33-2 Distribution: unstable Urgency: low Maintainer: Iulian Udrea <iul...@ubuntu.com> Changed-By: Iulian Udrea <iul...@ubuntu.com> Description: guilt - quilt for git; similar to Mercurial queues Closes: 589708 Changes: guilt (0.33-2) unstable; urgency=low . * Bump Standards-Version to 3.9.1 (no changes required). * Add depends on git (<< 1:1.8). Thanks Jonathan for the patch. Closes: #589708 Checksums-Sha1: 5fc6a0721c686479ebfd5d713de8de184a3b5d1e 1198 guilt_0.33-2.dsc ef1808aa91b1e6c69d7ecf9bb5dded2a02450507 4046 guilt_0.33-2.diff.gz a59b117158578c780ec126f7d09298e44c9b6e0a 56794 guilt_0.33-2_all.deb Checksums-Sha256: 9257735ad9f2405e39dcc59d3e9045dde731f73e1c2840dcec9881b21a86c519 1198 guilt_0.33-2.dsc f704a1886e6bd105a9511ccf451632d3149008b8bc58dc31b6bb9ee4c5a74375 4046 guilt_0.33-2.diff.gz e64a3b4d921d87e4f5bc33a9e44f56e4d11186440c92c0ce7cba149ce684b7e3 56794 guilt_0.33-2_all.deb Files: c78060a6d2cb3e95e732ef1f3972275b 1198 devel optional guilt_0.33-2.dsc a4ac607c2d08c7432ed8ebaa3f6b001e 4046 devel optional guilt_0.33-2.diff.gz d7db048c8c55ef5ebaa769cc77283149 56794 devel optional guilt_0.33-2_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkxVob8ACgkQWLKfjPdOxsgEAQCeI+X91qzOBNkJuZNpIrSQQbpS vpcAnRtRuXFifxnMY6rSXVM0EJsaDes3 =P62o -----END PGP SIGNATURE-----
--- End Message ---
