Hi,
2010/4/19 Loïc Minier <l...@dooz.org>:
> On Mon, Apr 19, 2010, Nobuhiro Iwamatsu wrote:
>> I made the patch which revised this problem.
>> However, this patch is support of only after gtk-2.20.
>> I think that we had better check a version of gtk in configure.
Yes. I think that I had better turn on the check of the version than
I do this exclusively for gtk-2.20.
>
> A check in configure would require using an ifdef everytime the macro
> is used in the sources; perhaps we should just test with ifdef whether
> GTK_WIDGET_REALIZED is already set?
>
> e.g.
> /* should be dropped once we require gtk+ >= 2.20 */
> #ifndef GTK_WIDGET_REALIZED
> #define GTK_WIDGET_REALIZED gtk_widget_get_realized
> #endif
>
> or something like that; perhaps the other way around:
> /* compatibility with older Gtk+s */
> #if ! GTK_CHECK_VERSION(2,20,0)
> #define gtk_widget_get_realized GTK_WIDGET_REALIZED
> #endif
>
> ...that requires changing all GTK_WIDGET_REALIZED() to
> gtk_widget_get_realized(), but at least the code reads like code
> targetted at the most recent Gtk+.
>
Because unstable is gtk-2.20, it is not necessary to surround it with if-endif.
However, I thought that we have had better do even a version of other
gtk to the
patch which worked when we sent this patch to upstream.
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
