Package: pidgin
Severity: serious

Hi,
pidgin currently crashes when a broken GStreamer plugin is installed,
e.g. if this plugin crashes on initialization. See bug #573269 for an
example.

This only affects pidgin because the pidgin developers decided for some
reason, that the GStreamer registry updating should happen in the pidgin
process... which then of course makes it impossible to survive crashing
plugins.

Attached patch fixes this, you should *really* include it with the next
upload. When the registry updating is done in a forked, new process,
broken plugins will be blacklisted and deactivated instead of taking
down pidgin.

Of course bug #573269 is still a gst-plugins-bad0.10 (or LV2/liblrdf)
bug but not really critical.
Description: Upstream changes introduced in version 2.6.6-2.1
 This patch has been created by dpkg-source during the package build.
 Here's the last changelog entry, hopefully it gives details on why
 those changes were made:
 .
 pidgin (2.6.6-2.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   *
 .
 The person named in the Author field signed this changelog entry.
Author: Sebastian Dröge <sl...@debian.org>

---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>

--- pidgin-2.6.6.orig/pidgin/gtksound.c
+++ pidgin-2.6.6/pidgin/gtksound.c
@@ -307,9 +307,6 @@ pidgin_sound_init(void)
 
 #ifdef USE_GSTREAMER
        purple_debug_info("sound", "Initializing sound output drivers.\n");
-#ifdef GST_CAN_DISABLE_FORKING
-       gst_registry_fork_set_enabled (FALSE);
-#endif
        if ((gst_init_failed = !gst_init_check(NULL, NULL, &error))) {
                purple_notify_error(NULL, _("GStreamer Failure"),
                                        _("GStreamer failed to initialize."),
--- pidgin-2.6.6.orig/finch/gntsound.c
+++ pidgin-2.6.6/finch/gntsound.c
@@ -359,11 +359,6 @@ finch_sound_init(void)
        
 #ifdef USE_GSTREAMER
        purple_debug_info("sound", "Initializing sound output drivers.\n");
-#if (GST_VERSION_MAJOR > 0 || \
-       (GST_VERSION_MAJOR == 0 && GST_VERSION_MINOR > 10) || \
-        (GST_VERSION_MAJOR == 0 && GST_VERSION_MINOR == 10 && 
GST_VERSION_MICRO >= 10))
-       gst_registry_fork_set_enabled(FALSE);
-#endif
        if ((gst_init_failed = !gst_init_check(NULL, NULL, &error))) {
                purple_notify_error(NULL, _("GStreamer Failure"),
                                        _("GStreamer failed to initialize."),

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to