Your message dated Tue, 09 Mar 2010 19:17:09 +0000 with message-id <e1np4vv-00026l...@ries.debian.org> and subject line Bug#562901: fixed in couchdb 0.10.1-2 has caused the Debian Bug report #562901, regarding couchdb: wrong use of killall in preinst without pre-depends to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 562901: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=562901 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: couchdb Version: 0.10.0-1 Severity: serious Tags: patch Justification: Policy 3.5 User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu lucid ubuntu-patch The current version of couchdb calls killall in the preinst, with the following rationale: * Created debian/preinst, now we make sure that couchdb isn't running any beam processes on upgrade. Upgrading from 0.9.0-2 was leaving old code in a running beam process, so you were running 0.9.0 couchdb but had 0.10.0 code installed until you killed the process. Adds a dependency on psmisc. This is broken, because: - You did not add psmisc as a pre-depends of the package as required, you added it as a build-depends. This is a violation of Policy 3.5. - You have not discussed this on debian-devel prior to adding the (logical) pre-dependency. This is also a violation of a Policy 3.5 "should" requirement. - Your killall command is helplessly incorrect. Processes running as the couchdb user should be managed by the init script, and it should be regarded as a bug in the init script if they aren't being stopped on upgrade. Processes running as users *other* than the couchdb user are not affected by the killall command (and should not be), so whatever problem this preinst was meant to work around is still going to affect those users. I recommend dropping this change entirely, as in the following patch, and if necessary improving the init script to correctly manage these processes. === modified file 'debian/control' --- debian/control 2009-11-21 17:10:39 +0000 +++ debian/control 2009-12-28 22:08:47 +0000 @@ -6,7 +6,7 @@ Standards-Version: 3.8.3 Build-Depends: cdbs (>= 0.4.42), debhelper (>= 7.2.11), erlang-dev (>= 1:13.b.1-dfsg-3), help2man, libcurl4-openssl-dev, - libicu-dev, libmozjs-dev, libreadline-dev, psmisc + libicu-dev, libmozjs-dev, libreadline-dev Homepage: http://couchdb.apache.org/ Vcs-Svn: svn+ssh://svn.debian.org/svn/pkg-erlang/couchdb Vcs-Browser: http://svn.debian.org/viewsvn/pkg-erlang/couchdb === removed file 'debian/preinst' --- debian/preinst 2009-11-21 17:10:39 +0000 +++ debian/preinst 1970-01-01 00:00:00 +0000 @@ -1,29 +0,0 @@ -#!/bin/sh -e -# by Sam Bisbee <sbis...@computervip.com> Copyright 2009 -# The right to copy, distribute, and modify this file in any medium is released -# to anyone without royalty, provided that this notice and the copyright notice -# is preserved. - -case "$1" in - install) - ;; - - upgrade) - #Prevent old couchdb code from running in a couchdb process and surviving - #through to our new version. Assumes that it's running as the default - #couchdb user. - killall -q -u couchdb beam > /dev/null || true - ;; - - abort-upgrade) - ;; - - *) - echo "preinst called with unknown argument $1" >&2 - exit 1 - ;; -esac - -#DEBHELPER# - -exit 0 Cheers, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
--- End Message ---
--- Begin Message ---Source: couchdb Source-Version: 0.10.1-2 We believe that the bug you reported is fixed in the latest version of couchdb, which is due to be installed in the Debian FTP archive: couchdb_0.10.1-2.diff.gz to main/c/couchdb/couchdb_0.10.1-2.diff.gz couchdb_0.10.1-2.dsc to main/c/couchdb/couchdb_0.10.1-2.dsc couchdb_0.10.1-2_i386.deb to main/c/couchdb/couchdb_0.10.1-2_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 562...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sam Bisbee <sbis...@computervip.com> (supplier of updated couchdb package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Tue, 09 Mar 2010 21:55:59 +0300 Source: couchdb Binary: couchdb Architecture: source i386 Version: 0.10.1-2 Distribution: unstable Urgency: low Maintainer: Erlang Packaging Team <pkg-erlang-de...@lists.alioth.debian.org> Changed-By: Sam Bisbee <sbis...@computervip.com> Description: couchdb - RESTful document oriented database Closes: 562901 569965 Changes: couchdb (0.10.1-2) unstable; urgency=low . [ Elliot Murphy ] * Updated debian/control, added Elliot to Uploaders * Dropped $ENABLE_SERVER portion of debian/patches/init.patch . [ Sam Bisbee ] * Updated debian/patches/init.patch, adding a grace period to the init script's stop task to allow couchdb's child processes (ie., heart) a chance to exit before deciding whether the task was successful or not. This adds a dependency on procps (`ps` command). * Removed debian/preinst, undoing killall preinst patch from 0.10.0-1 that is no longer needed due to the grace period init patch in this release. This also removes the dependency on psmisc. (closes: #562901) * Updated debian/control, bumping Debian standards version to 3.8.4. * Updated debian/control, adding mawk as a dependency. The majority of systems will have it installed with the base system, but it's required and not essential. (closes: #569965) Checksums-Sha1: 9d177fa8a9b1e9aca7e3d19753cc4cc44572ba2f 1379 couchdb_0.10.1-2.dsc 97fd44bd663913cf673f9a34efec4e4776444f36 7238 couchdb_0.10.1-2.diff.gz e784ce27341b50693ea6b1e189ae2f1efefbcc6a 532684 couchdb_0.10.1-2_i386.deb Checksums-Sha256: 0f69051256710d05d7d797508023aaa416af53b4b687ea7d9bc5301f3a7c2d24 1379 couchdb_0.10.1-2.dsc b2c2913d3390ebfd4fbabd0794ecbc15da378e2a7542c00ba09260350e46c6f1 7238 couchdb_0.10.1-2.diff.gz 477ae56f98870899bf62c71b6d45262fb82bc5c6f4cd28d8d73d006b246b2a69 532684 couchdb_0.10.1-2_i386.deb Files: b97a8b71b7dd8ffd5cf1094bfde56522 1379 misc optional couchdb_0.10.1-2.dsc c62bda002d6ffe743f175c680e2722a4 7238 misc optional couchdb_0.10.1-2.diff.gz c6f6a0a00ebf11881931326ccb4c64ef 532684 misc optional couchdb_0.10.1-2_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iD8DBQFLlptsIcdH02pGEFIRAnRDAKCOTT4wSrwjHaOX1oRLYnYut/3LiwCfVTnd ojr8Z+350NeTofcH7HHQy2Y= =F3Gf -----END PGP SIGNATURE-----
--- End Message ---
