Your message dated Sun, 21 Aug 2005 00:47:04 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#324050: fixed in soundmodem 0.9-2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 20 Aug 2005 01:13:41 +0000
>From [EMAIL PROTECTED] Fri Aug 19 18:13:41 2005
Return-path: <[EMAIL PROTECTED]>
Received: from zoot.lafn.org [206.117.18.6] 
        by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
        id 1E6HvZ-000091-00; Fri, 19 Aug 2005 18:13:41 -0700
Received: from localhost.localdomain 
(pool-71-104-166-233.lsanca.dsl-w.verizon.net [71.104.166.233])
        (authenticated bits=0)
        by zoot.lafn.org (8.13.1/8.13.1) with ESMTP id j7K1Ddr9046396
        (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO)
        for <[EMAIL PROTECTED]>; Fri, 19 Aug 2005 18:13:39 -0700 (PDT)
        (envelope-from [EMAIL PROTECTED])
Received: from kraai by localhost.localdomain with local (Exim 4.52)
        id 1E6BgC-00017o-3R
        for [EMAIL PROTECTED]; Fri, 19 Aug 2005 11:33:24 -0700
Date: Fri, 19 Aug 2005 11:33:23 -0700
From: Matt Kraai <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: FTBFS: Jumps into statement expressions
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="jq0ap7NbKX2Kqbes"
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
X-Virus-Scanned: ClamAV 0.86.2/1034/Thu Aug 18 13:07:58 2005 on zoot.lafn.org
X-Virus-Status: Clean
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
        version=2.60-bugs.debian.org_2005_01_02


--jq0ap7NbKX2Kqbes
Content-Type: multipart/mixed; boundary="tKW2IUtsqtDRztdT"
Content-Disposition: inline


--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: soundmodem
Version: 0.9-1
Severity: serious
Tags: patch

soundmodem fails to build because it contains jumps into statement
expressions:

> if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/gnome-xml -I../matlib =
-I../libmisc -I../directx/include -I../directx/include/directx6     -g -O2 =
-Wall -O2 -MT kisspkt.o -MD -MP -MF ".deps/kisspkt.Tpo" \
>   -c -o kisspkt.o `test -f 'kisspkt.c' || echo './'`kisspkt.c; \
> then mv -f ".deps/kisspkt.Tpo" ".deps/kisspkt.Po"; \
> else rm -f ".deps/kisspkt.Tpo"; exit 1; \
> fi
> kisspkt.c: In function 'hdlc_encode':
> kisspkt.c:221: error: jump into statement expression
> kisspkt.c:230: error: jump into statement expression
> kisspkt.c:222: error: jump into statement expression
> kisspkt.c:231: error: jump into statement expression
> kisspkt.c:223: error: jump into statement expression
> kisspkt.c:232: error: jump into statement expression
> kisspkt.c:224: error: jump into statement expression
> kisspkt.c:233: error: jump into statement expression
> kisspkt.c:225: error: jump into statement expression
> kisspkt.c:234: error: jump into statement expression
> kisspkt.c:226: error: jump into statement expression
> kisspkt.c:235: error: jump into statement expression
> kisspkt.c:227: error: jump into statement expression
> kisspkt.c:236: error: jump into statement expression
> kisspkt.c:228: error: jump into statement expression
> kisspkt.c:237: error: jump into statement expression
> kisspkt.c:237: warning: label 'encodeend7' defined but not used
> kisspkt.c:236: warning: label 'encodeend6' defined but not used
> kisspkt.c:235: warning: label 'encodeend5' defined but not used
> kisspkt.c:234: warning: label 'encodeend4' defined but not used
> kisspkt.c:233: warning: label 'encodeend3' defined but not used
> kisspkt.c:232: warning: label 'encodeend2' defined but not used
> kisspkt.c:231: warning: label 'encodeend1' defined but not used
> kisspkt.c:230: warning: label 'encodeend0' defined but not used
> kisspkt.c: In function 'hdlc_receive':
> kisspkt.c:360: error: jump into statement expression
> kisspkt.c:369: error: jump into statement expression
> kisspkt.c:369: error: jump into statement expression
> kisspkt.c:369: error: jump into statement expression
> kisspkt.c:360: error: jump into statement expression
> kisspkt.c:369: error: jump into statement expression
> kisspkt.c:361: error: jump into statement expression
> kisspkt.c:370: error: jump into statement expression
> kisspkt.c:370: error: jump into statement expression
> kisspkt.c:370: error: jump into statement expression
> kisspkt.c:361: error: jump into statement expression
> kisspkt.c:370: error: jump into statement expression
> kisspkt.c:362: error: jump into statement expression
> kisspkt.c:371: error: jump into statement expression
> kisspkt.c:371: error: jump into statement expression
> kisspkt.c:371: error: jump into statement expression
> kisspkt.c:362: error: jump into statement expression
> kisspkt.c:371: error: jump into statement expression
> kisspkt.c:363: error: jump into statement expression
> kisspkt.c:372: error: jump into statement expression
> kisspkt.c:372: error: jump into statement expression
> kisspkt.c:372: error: jump into statement expression
> kisspkt.c:363: error: jump into statement expression
> kisspkt.c:372: error: jump into statement expression
> kisspkt.c:364: error: jump into statement expression
> kisspkt.c:373: error: jump into statement expression
> kisspkt.c:373: error: jump into statement expression
> kisspkt.c:373: error: jump into statement expression
> kisspkt.c:364: error: jump into statement expression
> kisspkt.c:373: error: jump into statement expression
> kisspkt.c:365: error: jump into statement expression
> kisspkt.c:374: error: jump into statement expression
> kisspkt.c:374: error: jump into statement expression
> kisspkt.c:374: error: jump into statement expression
> kisspkt.c:365: error: jump into statement expression
> kisspkt.c:374: error: jump into statement expression
> kisspkt.c:366: error: jump into statement expression
> kisspkt.c:375: error: jump into statement expression
> kisspkt.c:375: error: jump into statement expression
> kisspkt.c:375: error: jump into statement expression
> kisspkt.c:366: error: jump into statement expression
> kisspkt.c:375: error: jump into statement expression
> kisspkt.c:367: error: jump into statement expression
> kisspkt.c:376: error: jump into statement expression
> kisspkt.c:376: error: jump into statement expression
> kisspkt.c:376: error: jump into statement expression
> kisspkt.c:367: error: jump into statement expression
> kisspkt.c:376: error: jump into statement expression
> kisspkt.c:376: warning: label 'enditer7' defined but not used
> kisspkt.c:375: warning: label 'enditer6' defined but not used
> kisspkt.c:374: warning: label 'enditer5' defined but not used
> kisspkt.c:373: warning: label 'enditer4' defined but not used
> kisspkt.c:372: warning: label 'enditer3' defined but not used
> kisspkt.c:371: warning: label 'enditer2' defined but not used
> kisspkt.c:370: warning: label 'enditer1' defined but not used
> kisspkt.c:369: warning: label 'enditer0' defined but not used
> kisspkt.c: In function 'kiss_input':
> kisspkt.c:498: warning: pointer targets in assignment differ in signedness
> kisspkt.c:507: warning: pointer targets in passing argument 2 of 'kiss_de=
code' differ in signedness
> kisspkt.c: In function 'p3dreceive':
> kisspkt.c:590: warning: unused variable 'i'

The attached patch converts the statement expressions to statements,
which fixes this problem.

--=20
Matt

--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
Content-Transfer-Encoding: quoted-printable

--- soundmodem-0.9.orig/soundcard/kisspkt.c
+++ soundmodem-0.9/soundcard/kisspkt.c
@@ -177,14 +177,14 @@
  */
=20
 #define ENCODEITERA(j)                         \
-({                                             \
+do {                                           \
         if (!(notbitstream & (0x1f0 << j)))    \
                 goto stuff##j;                 \
   encodeend##j:;                               \
-})
+} while (0)
=20
 #define ENCODEITERB(j)                                          \
-({                                                              \
+do {                                                            \
   stuff##j:                                                     \
         bitstream &=3D ~(0x100 << j);                             \
         bitbuf =3D (bitbuf & (((2 << j) << numbit) - 1)) |        \
@@ -192,7 +192,7 @@
         numbit++;                                               \
         notbitstream =3D ~bitstream;                              \
         goto encodeend##j;                                      \
-})
+} while (0)
=20
 static void hdlc_encode(struct modemchannel *chan, unsigned char *pkt, uns=
igned int len)
 {
@@ -309,16 +309,16 @@
 }
=20
 #define DECODEITERA(j)                                                    =
    \
-({                                                                        =
    \
+do {                                                                      =
    \
         if (!(notbitstream & (0x0fc << j)))              /* flag or abort =
*/  \
                 goto flgabrt##j;                                          =
    \
         if ((bitstream & (0x1f8 << j)) =3D=3D (0xf8 << j))   /* stuffed bi=
t */    \
                 goto stuff##j;                                            =
    \
   enditer##j:;                                                            =
    \
-})
+} while (0)
=20
 #define DECODEITERB(j)                                                    =
             \
-({                                                                        =
             \
+do {                                                                      =
             \
   flgabrt##j:                                                             =
             \
         if (!(notbitstream & (0x1fc << j))) {              /* abort receiv=
ed */        \
                 state =3D 0;                                              =
               \
@@ -337,7 +337,7 @@
         numbits--;                                                        =
             \
         bitbuf =3D (bitbuf & ((~0xff) << j)) | ((bitbuf & ~((~0xff) << j))=
 << 1);        \
         goto enditer##j;                                                  =
             \
-})
+} while (0)
        =20
 static inline void hdlc_receive(struct modemchannel *chan, const unsigned =
char *data, unsigned nrbytes)
 {
only in patch2:
unchanged:
--- soundmodem-0.9.orig/configapp/src/diag.c
+++ soundmodem-0.9/configapp/src/diag.c
@@ -208,16 +208,16 @@
 }
=20
 #define DECODEITERA(j)                                                    =
    \
-({                                                                        =
    \
+do {                                                                      =
    \
         if (!(notbitstream & (0x0fc << j)))              /* flag or abort =
*/  \
                 goto flgabrt##j;                                          =
    \
         if ((bitstream & (0x1f8 << j)) =3D=3D (0xf8 << j))   /* stuffed bi=
t */    \
                 goto stuff##j;                                            =
    \
   enditer##j:;                                                            =
    \
-})
+} while (0)
=20
 #define DECODEITERB(j)                                                    =
             \
-({                                                                        =
             \
+do {                                                                      =
             \
   flgabrt##j:                                                             =
             \
         if (!(notbitstream & (0x1fc << j))) {              /* abort receiv=
ed */        \
                 state =3D 0;                                              =
               \
@@ -236,7 +236,7 @@
         numbits--;                                                        =
             \
         bitbuf =3D (bitbuf & ((~0xff) << j)) | ((bitbuf & ~((~0xff) << j))=
 << 1);        \
         goto enditer##j;                                                  =
             \
-})
+} while (0)
        =20
 static inline void hdlc_receive(const unsigned char *data, unsigned nrbyte=
s)
 {

--tKW2IUtsqtDRztdT--

--jq0ap7NbKX2Kqbes
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDBiXzfNdgYxVXvBARAkGmAKCjj/8cCjomEC3JhjeFbh4p8DsSuQCgkZOC
Z2IMbn2AyCnZ7d+woAmjnTQ=
=0Zss
-----END PGP SIGNATURE-----

--jq0ap7NbKX2Kqbes--

---------------------------------------
Received: (at 324050-close) by bugs.debian.org; 21 Aug 2005 07:50:15 +0000
>From [EMAIL PROTECTED] Sun Aug 21 00:50:15 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
        id 1E6kXo-0002WR-00; Sun, 21 Aug 2005 00:47:04 -0700
From: Joop Stakenborg <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#324050: fixed in soundmodem 0.9-2
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sun, 21 Aug 2005 00:47:04 -0700
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: soundmodem
Source-Version: 0.9-2

We believe that the bug you reported is fixed in the latest version of
soundmodem, which is due to be installed in the Debian FTP archive:

soundmodem_0.9-2.diff.gz
  to pool/main/s/soundmodem/soundmodem_0.9-2.diff.gz
soundmodem_0.9-2.dsc
  to pool/main/s/soundmodem/soundmodem_0.9-2.dsc
soundmodem_0.9-2_i386.deb
  to pool/main/s/soundmodem/soundmodem_0.9-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joop Stakenborg <[EMAIL PROTECTED]> (supplier of updated soundmodem package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 20 Aug 2005 10:32:59 +0200
Source: soundmodem
Binary: soundmodem
Architecture: source i386
Version: 0.9-2
Distribution: unstable
Urgency: low
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Joop Stakenborg <[EMAIL PROTECTED]>
Description: 
 soundmodem - Sound Card Amateur Packet Radio Modems
Closes: 324050
Changes: 
 soundmodem (0.9-2) unstable; urgency=low
 .
   * A fix for jumps into statement expressions. Patch by Matt Kraai, thanks!
     Closes: #324050.
   * Upload for the Debian Hamradio Maintainers Pool.
Files: 
 511dfad6065820d26ce64c24823aa25f 881 hamradio optional soundmodem_0.9-2.dsc
 f77cd9af18b0597ca7fcf5d04475a246 30433 hamradio optional 
soundmodem_0.9-2.diff.gz
 16b8fafaa358c3b50c4fec0c184be5a3 157134 hamradio optional 
soundmodem_0.9-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDCC5ynuUI/ps3DJoRAq7QAJ41CIEQebzyTzgIxOuo+TgVj7zu3QCeJq2/
y72l+Fu/YbPE5Oz8Z8VLgo0=
=rPTO
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to