Your message dated Tue, 22 Dec 2009 15:23:12 +0000
with message-id <e1nn6zs-00023f...@ries.debian.org>
and subject line Bug#554494: fixed in pfstools 1.8.1-1.1
has caused the Debian Bug report #554494,
regarding pfstools: FTBFS with latest gcc 4.4 and glibc 2.10 with an invalid
conversion from const char * to const *
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
554494: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=554494
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pfstools
Version: 1.8.1-1
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch
Hi,
When compiling pfstools for Karmic, we got the following compilation error:
i486-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -I./../pfs -O3 -Wall -MT
pfspanoramic.o -MD -MP -MF .deps/pfspanoramic.Tpo -c -o pfspanoramic.o
pfspanoramic.cpp
pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateX(double)':
pfspanoramic.cpp:108: warning: no return statement in function returning
non-void
pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateY(double)':
pfspanoramic.cpp:122: warning: no return statement in function returning
non-void
pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateZ(double)':
pfspanoramic.cpp:136: warning: no return statement in function returning
non-void
pfspanoramic.cpp: In static member function 'static Projection*
ProjectionFactory::getProjection(const char*)':
pfspanoramic.cpp:198: error: invalid conversion from 'const char*' to 'char*'
pfspanoramic.cpp:198: warning: suggest parentheses around assignment used as
truth value
pfspanoramic.cpp: In member function 'virtual Vector3D*
MirrorBallProjection::uvToDirection(double, double)':
pfspanoramic.cpp:279: warning: unused variable 't'
pfspanoramic.cpp: In member function 'virtual Vector3D*
AngularProjection::uvToDirection(double, double)':
pfspanoramic.cpp:397: warning: unused variable 't'
pfspanoramic.cpp: In function 'void panoramic(int, char**)':
pfspanoramic.cpp:794: warning: unused variable 'dX'
pfspanoramic.cpp:794: warning: unused variable 'dY'
pfspanoramic.cpp:794: warning: unused variable 'dZ'
make[4]: *** [pfspanoramic.o] Error 1
make[4]: Leaving directory `/build/buildd/pfstools-1.8.1/src/filter'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/build/buildd/pfstools-1.8.1/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/build/buildd/pfstools-1.8.1'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/build/buildd/pfstools-1.8.1'
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Upstream proposed the fix in the attached patch at
http://sourceforge.net/tracker/index.php?func=detail&aid=2848391&group_id=129921&atid=716245
and should be apply to Debian also, to avoid compilation a compilation error
with latest gcc 4.4 and glibc 2.10.
Thanks,
Fabrice
*** /tmp/tmptnQa0k
In Ubuntu, we've applied the attached patch to achieve the following:
* debian/patches/gcc-4.4.dpatch: fix line 194 of src/filter/pfspanoramic.cpp
to avoid a compilation error (LP: #429629)
* debian/patches/00list: added gcc-4.4.dpatch
We thought you might be interested in doing the same.
-- System Information:
Debian Release: squeeze/sid
APT prefers karmic-updates
APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.31-14-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
diff -u pfstools-1.8.1/debian/patches/00list pfstools-1.8.1/debian/patches/00list
--- pfstools-1.8.1/debian/patches/00list
+++ pfstools-1.8.1/debian/patches/00list
@@ -2,2 +2,3 @@
octave-signal.dpatch
+gcc-4.4.dpatch
only in patch2:
unchanged:
--- pfstools-1.8.1.orig/debian/patches/gcc-4.4.dpatch
+++ pfstools-1.8.1/debian/patches/gcc-4.4.dpatch
@@ -0,0 +1,19 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## gcc-4.4.dpatch by Fabrice Coutadeur <fabric...@ubuntu.com>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Fix compilation error with GCC 4.4. Fix get from http://sourceforge.net/tracker/index.php?func=detail&aid=2848391&group_id=129921&atid=716245
+
+...@dpatch@
+diff -urNad pfstools-1.8.1~/src/filter/pfspanoramic.cpp pfstools-1.8.1/src/filter/pfspanoramic.cpp
+--- pfstools-1.8.1~/src/filter/pfspanoramic.cpp 2008-07-29 16:14:30.000000000 +0000
++++ pfstools-1.8.1/src/filter/pfspanoramic.cpp 2009-09-10 20:11:29.000000000 +0000
+@@ -191,7 +191,7 @@
+ singleton.projections[ string( name ) ] = ptr;
+ }
+
+- static Projection *getProjection(const char *name)
++ static Projection *getProjection(char *name)
+ {
+ char *opts;
+
--- End Message ---
--- Begin Message ---
Source: pfstools
Source-Version: 1.8.1-1.1
We believe that the bug you reported is fixed in the latest version of
pfstools, which is due to be installed in the Debian FTP archive:
libpfs-1.2-0_1.8.1-1.1_amd64.deb
to main/p/pfstools/libpfs-1.2-0_1.8.1-1.1_amd64.deb
libpfs-dev_1.8.1-1.1_amd64.deb
to main/p/pfstools/libpfs-dev_1.8.1-1.1_amd64.deb
octave-pfstools_1.8.1-1.1_amd64.deb
to main/p/pfstools/octave-pfstools_1.8.1-1.1_amd64.deb
pfsglview_1.8.1-1.1_amd64.deb
to main/p/pfstools/pfsglview_1.8.1-1.1_amd64.deb
pfstools-dbg_1.8.1-1.1_amd64.deb
to main/p/pfstools/pfstools-dbg_1.8.1-1.1_amd64.deb
pfstools_1.8.1-1.1.diff.gz
to main/p/pfstools/pfstools_1.8.1-1.1.diff.gz
pfstools_1.8.1-1.1.dsc
to main/p/pfstools/pfstools_1.8.1-1.1.dsc
pfstools_1.8.1-1.1_amd64.deb
to main/p/pfstools/pfstools_1.8.1-1.1_amd64.deb
pfsview_1.8.1-1.1_amd64.deb
to main/p/pfstools/pfsview_1.8.1-1.1_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 554...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stefano Zacchiroli <z...@debian.org> (supplier of updated pfstools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 20 Dec 2009 15:12:00 +0100
Source: pfstools
Binary: pfstools pfsglview pfsview pfstools-dbg libpfs-dev libpfs-1.2-0
octave-pfstools
Architecture: source amd64
Version: 1.8.1-1.1
Distribution: unstable
Urgency: low
Maintainer: Debian PhotoTools Maintainers
<pkg-phototools-de...@lists.alioth.debian.org>
Changed-By: Stefano Zacchiroli <z...@debian.org>
Description:
libpfs-1.2-0 - C++ library to read and write pfs files
libpfs-dev - C++ library to read and write pfs files (development files)
octave-pfstools - octave bindings for pfstools
pfsglview - command line HDR manipulation programs (OpenGL/GLUT viewer)
pfstools - command line HDR manipulation programs
pfstools-dbg - command line HDR manipulation programs (debugging symbols)
pfsview - command line HDR manipulation programs (Qt viewer)
Closes: 554494
Changes:
pfstools (1.8.1-1.1) unstable; urgency=low
.
* Non-maintainer upload.
* Add patch gcc-4.4.dpatch, to fix FTBFS w/ gcc 4.4, rationale; patch
from Ubuntu (with some extra comments/rationale by me).
(Closes: #554494)
Checksums-Sha1:
f56de52bcb63de3b7700585dd175517c1d1e0671 1494 pfstools_1.8.1-1.1.dsc
113b9c8768e0635868d7f5d79660adef5faeb44e 5820 pfstools_1.8.1-1.1.diff.gz
ff0e31f847022d2e48b8c478cd05a30a7b9e3a5d 300506 pfstools_1.8.1-1.1_amd64.deb
cfb6dd57d1555bbfff05b8972f63d583da114660 32826 pfsglview_1.8.1-1.1_amd64.deb
3777023cab152479c84e5d0637d137175fd02fa6 56314 pfsview_1.8.1-1.1_amd64.deb
58f809529706dafe3e909f0b203c9b70878a80e5 65256 pfstools-dbg_1.8.1-1.1_amd64.deb
97a67529f395f463ebc6850a616f81ca559cbc9b 39628 libpfs-dev_1.8.1-1.1_amd64.deb
844f898f364d798a40768d5b61c87c5bbcf2fe8c 28732 libpfs-1.2-0_1.8.1-1.1_amd64.deb
19a6100cdeb406cd899e6e88b34b1e048cae7b87 128634
octave-pfstools_1.8.1-1.1_amd64.deb
Checksums-Sha256:
fd4d8a840430ed9d6abd9a62da8b85bc7790cd2c200a99a6faf3c723b9fa637e 1494
pfstools_1.8.1-1.1.dsc
1b4be9b2469b971ed8ce55532c776df2d94150dffcfc3fd11d62c26479f93511 5820
pfstools_1.8.1-1.1.diff.gz
51b44b291ee38e35b7ebea197b9a73821ce7505519dbdaaaeb729454e88b9b9f 300506
pfstools_1.8.1-1.1_amd64.deb
c882bfb5519126941e7efc1033297f7fdbdb9b5bb885e963b9cf03a2a105dca0 32826
pfsglview_1.8.1-1.1_amd64.deb
10352e75e49366566ccf05f8c167c155767d25d7ec8a9cc490c638bc31d1cbac 56314
pfsview_1.8.1-1.1_amd64.deb
90db0ba55f45237cd36382eec7174376e49a4b38d8e20c7b97503e9cad4da4fb 65256
pfstools-dbg_1.8.1-1.1_amd64.deb
3c6e2a1af0033b6421538218eb7fd21275c6563d8be0f4d9f9e7f02d32c8217b 39628
libpfs-dev_1.8.1-1.1_amd64.deb
e17b327a8bfe45e1e89d26bed13da03547fcd4b3a51e61026c70e7e85467c53d 28732
libpfs-1.2-0_1.8.1-1.1_amd64.deb
a1d5613c6ab8b64d886d9a97144b010a5e5bf95e0785462ce43b5990a9a6cbbf 128634
octave-pfstools_1.8.1-1.1_amd64.deb
Files:
407705f90b6c7f2cf1616f6ecbd5b025 1494 graphics optional pfstools_1.8.1-1.1.dsc
420fbe78601e5c170ce87c8ee60bc61f 5820 graphics optional
pfstools_1.8.1-1.1.diff.gz
3fcac57a3d4819999fbbcf7e52650618 300506 graphics optional
pfstools_1.8.1-1.1_amd64.deb
56c7ccba962eb56afbfd078a19b0a03e 32826 graphics optional
pfsglview_1.8.1-1.1_amd64.deb
b2a89c320f4b4639859d0d29fc7e7ce3 56314 graphics optional
pfsview_1.8.1-1.1_amd64.deb
3570c34b86ea756f53d62300bfeb52f9 65256 debug extra
pfstools-dbg_1.8.1-1.1_amd64.deb
fbd66eb15cb0627ca1601fd2ddc1c946 39628 libdevel optional
libpfs-dev_1.8.1-1.1_amd64.deb
91d6f0251979b9c18e58cfab57d682b3 28732 libs optional
libpfs-1.2-0_1.8.1-1.1_amd64.deb
89f8797fc15f0aa9d2d27fb6d04df5fc 128634 math optional
octave-pfstools_1.8.1-1.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iD8DBQFLLjXM1cqbBPLEI7wRAt98AKDaQZbL+dvuUe+mn+2QFgWs0GgU0QCghtPk
WljT+/U35U9nnA2Mvh7FGgY=
=V6H6
-----END PGP SIGNATURE-----
--- End Message ---
