Your message dated Sat, 03 Oct 2009 16:18:55 +0000
with message-id <e1mu7jv-0004fn...@ries.debian.org>
and subject line Bug#548306: fixed in batmand 0.3.2-3
has caused the Debian Bug report #548306,
regarding batmand: Incorrect runlevels and dependencies in init.d LSB header
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
548306: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=548306
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: batmand
Version: 0.2-1
Severity: serious
Tags: patch
User: initscripts-ng-de...@lists.alioth.debian.org
Usertags: incorrect-dependency incorrect-runlevels
User: debian...@lists.debian.org
Usertags: piuparts
With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d scripts of this package. The package uses files
in /usr/ but do not depend on $remote_fs. The runlevel settings when
using legacu boot ordering do not match the init.d script header. The
package fail to install if the netbase is not installed, yet the
netbase package is not a package dependency. To avoid this it is
better to depend on $network. Last, the script used to start after
syslog in runels 2-5, but do not depend on $syslog. The installation
problem was discovered by piuparts, see <URL:
http://piuparts.debian.org/sid/fail/batmand_0.3.2-2.log > for the test
log. These are the error messages:
update-rc.d: warning: batmand start runlevel arguments (2 3 4 5) do
not match LSB Default-Start values (S)
update-rc.d: warning: batmand stop runlevel arguments (0 1 6) do not
match LSB Default-Stop values (0 6)
insserv: Service networking has to be enabled to start service batmand
insserv: Service ifupdown has to be enabled to start service batmand
insserv: exiting now!
<URL:
http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
>
documents the LSB header format. Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.
This patch should solve the issue. Without it, the package fail to
install when netbase isn't installed, and will start a bit too early
during boot. As the stop action in the init.d scrtip is just to kill
the daemon, the stop links in runlevels 0 and 6 can be dropped as
sendsigs will kill the daemon more efficiently. The postinst fragment
is to detect installations with the old runlevels, and remove the
symlinks to let debhelper insert the correct runlevels, and the rules
change is to make sure legacy ordering uses the same runlevels as the
dependency based boot ordering.
diff -N -ur ../batmand-0.3.2/debian/batmand.init
../batmand-0.3.2-pere/debian/batmand.init
--- ../batmand-0.3.2/debian/batmand.init 2009-09-25 13:16:19.000000000
+0200
+++ ../batmand-0.3.2-pere/debian/batmand.init 2009-09-25 13:22:09.000000000
+0200
@@ -1,10 +1,10 @@
#! /bin/sh
### BEGIN INIT INFO
# Provides: batmand
-# Required-Start: networking ifupdown $local_fs
-# Required-Stop: $local_fs
-# Default-Start: S
-# Default-Stop: 0 6
+# Required-Start: $network $remote_fs $syslog
+# Required-Stop: $network $remote_fs $syslog
+# Default-Start: 2 3 4 5
+# Default-Stop: 1
# Short-Description: /etc/init.d/batmand: start batmand
### END INIT INFO
diff -N -ur ../batmand-0.3.2/debian/batmand.postinst
../batmand-0.3.2-pere/debian/batmand.postinst
--- ../batmand-0.3.2/debian/batmand.postinst 1970-01-01 01:00:00.000000000
+0100
+++ ../batmand-0.3.2-pere/debian/batmand.postinst 2009-09-25
13:26:22.000000000 +0200
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+set -e
+
+# Recover from incorrect init.d script headers in version 0.3.2-2 and earlier
+if [ "$1" = "configure" ] && dpkg --compare-versions "$2" le "0.3.2-2" \
+ && [ -f /etc/rcS.d/S[0-9][0-9]batmand ] \
+ && ! [ -f /etc/rc2.d/S[0-9][0-9]batmand ] ; then
+ update-rc.d -f batmand remove
+fi
+
+#DEBHELPER#
diff -N -ur ../batmand-0.3.2/debian/rules ../batmand-0.3.2-pere/debian/rules
--- ../batmand-0.3.2/debian/rules 2009-09-25 13:16:19.000000000 +0200
+++ ../batmand-0.3.2-pere/debian/rules 2009-09-25 13:29:00.000000000 +0200
@@ -146,7 +146,7 @@
dh_installdocs -s
dh_installexamples -s
# dh_install -s
- dh_installinit -s
+ dh_installinit -s -u"start 20 2 3 4 5 . stop 20 1 ."
dh_installman -s
dh_link -s
dh_strip -s --dbg-package=batmand-dbg
Happy hacking,
--
Petter Reinholdtsen
--- End Message ---
--- Begin Message ---
Source: batmand
Source-Version: 0.3.2-3
We believe that the bug you reported is fixed in the latest version of
batmand, which is due to be installed in the Debian FTP archive:
batmand-dbg_0.3.2-3_amd64.deb
to pool/main/b/batmand/batmand-dbg_0.3.2-3_amd64.deb
batmand-gateway-source_0.3.2-3_all.deb
to pool/main/b/batmand/batmand-gateway-source_0.3.2-3_all.deb
batmand_0.3.2-3.diff.gz
to pool/main/b/batmand/batmand_0.3.2-3.diff.gz
batmand_0.3.2-3.dsc
to pool/main/b/batmand/batmand_0.3.2-3.dsc
batmand_0.3.2-3_amd64.deb
to pool/main/b/batmand/batmand_0.3.2-3_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 548...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sven Eckelmann <sven.eckelm...@gmx.de> (supplier of updated batmand package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 03 Oct 2009 17:49:25 +0200
Source: batmand
Binary: batmand batmand-dbg batmand-gateway-source
Architecture: source all amd64
Version: 0.3.2-3
Distribution: unstable
Urgency: low
Maintainer: Holger Levsen <hol...@debian.org>
Changed-By: Sven Eckelmann <sven.eckelm...@gmx.de>
Description:
batmand - better approach to mobile adhoc networking
batmand-dbg - better approach to mobile adhoc networking (debug files)
batmand-gateway-source - Source for the batmand-gateway kernel module
Closes: 548306
Changes:
batmand (0.3.2-3) unstable; urgency=low
.
[ Sven Eckelmann ]
* debian/patches:
- Change to dep3 patch tagging guidelines
- Remove number before patches as order is given by debian/patches/series
* Remove inactive maintainer Wesley Tsai from Uploaders in debian/control
* Override Lintian warning init.d-script-possible-missing-stop as sendsigs
will kill the daemon more efficiently
.
[ Petter Reinholdtsen ]
* Correct runlevels and dependencies in init.d LSB header (Closes: #548306)
* Add batmand.postinst to recover from incorrect init.d script headers in
previous versions
Checksums-Sha1:
bae6c8ade39bdce33b23e8c7614d758186378724 1243 batmand_0.3.2-3.dsc
7125a0553ce993ac1abe73da9e08125566a90adb 9747 batmand_0.3.2-3.diff.gz
246947a5096ad9bb646e63bac47d22c28ab8b362 24030
batmand-gateway-source_0.3.2-3_all.deb
1409f9d1f7f813a61bc4dd1b320edfbfe4807cc6 56198 batmand_0.3.2-3_amd64.deb
64015145a11a24986f9f849f90c7a7e66ea1fe6c 74930 batmand-dbg_0.3.2-3_amd64.deb
Checksums-Sha256:
8da1ae38ca6e13ad028f54f3cedcbd2db2d0b4453839dbbb4418ba6604eb2673 1243
batmand_0.3.2-3.dsc
c8c2673bff63b4b308a8aced36c99a34fb90184610342c3bdc5c4472a022385a 9747
batmand_0.3.2-3.diff.gz
471d6be5927e227f7ac2b13643effcc42cee96f1f7b1840f225d29d0ab794730 24030
batmand-gateway-source_0.3.2-3_all.deb
2339dd09d168141c2f5e780a30f6e523ae4a0380f92d70157c82d6ccb4cdad9b 56198
batmand_0.3.2-3_amd64.deb
b87ed5761fe2116872b89662fd5095f8ea418e91661fe052d26b7ad6d4fd6f02 74930
batmand-dbg_0.3.2-3_amd64.deb
Files:
5747f26ae8745d92dbb6104682aed0e6 1243 net extra batmand_0.3.2-3.dsc
eec5c66780574c987dbe5a924874727d 9747 net extra batmand_0.3.2-3.diff.gz
95f26a805e072dbd7eb983d65393ccea 24030 kernel extra
batmand-gateway-source_0.3.2-3_all.deb
8fdd09ba0972fe7c3ba014729f2cf61c 56198 net extra batmand_0.3.2-3_amd64.deb
dfecefa04165c1649f7650a556d19a14 74930 debug extra
batmand-dbg_0.3.2-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEAREKAAYFAkrHdCcACgkQqQGwKVlMoDuAVQCfUqrCc/nDOop9LjXByaBbYwRY
XIgAmwfyMjX8NeZxDzFJcM8Yu3lGQf0H
=gEe3
-----END PGP SIGNATURE-----
--- End Message ---
