Modestats, On Thu, Sep 17, 2009 at 12:22 PM, Modestas Vainius <modes...@vainius.eu> wrote: > affects 544674 - vtk > severity 544674 important > thanks > > Hello, > > On ketvirtadienis 17 Rugsėjis 2009 10:05:57 Mathieu Malaterre wrote: >> Please apply upstream patch that should solve this grave issue. >> >> Link: >> http://public.kitware.com/cgi-bin/viewcvs.cgi/Modules/FindJNI.cmake?root=CM >> ake&r1=1.40&r2=1.41 > > Mathieu, my previous arguments about your patch being arch-dependent still > hold true. I somehow missed that you reported upstream bug and I would say it > is rather unfortunate upstream accepted your patch. So I'm not going to rush > but talk with upstream about proper solution.
I would think that DD cannot replace whatever choice is being done upstream. > Secondly, fixing #544674 bug will NOT fix #545335. Current FindJNI.cmake > refers to $JAVA_HOME/ppc in the search path as it is supposed to (according to > openjdk-6-jre-headless package). There is no convention AFAIK. So unless you inspect all of them you will *not* find libjawt.so. The actual proper fix in debian would be to have all libjawt.so provider to install the symlinks properly. > Don't you find it weird that vtk builds just > *fine* with FindJNI.cmake on arches it supposedly does NOT support (according > to this bug) but fails on powerpc which it supports properly? This bug > obviously attracted too much false attention. No it does not build, see your own remark below. > FWIW, from vtk debian/rules: > > echo JAVA_AWT_LIBRARY:FILEPATH=/usr/lib/jvm/default- > java/jre/lib/$(DEB_HOST_ARCH_CPU)/libjawt.so >> Build/CMakeCache.txt That's just wrong. cmake is doing system inspection. This was written by someone not knowing the cmake enough. > So that's where the powerpc FTBFS is coming from. It *overrides* proper value > FindJNI sets on powerpc. It is also true that you cannot drop this workaround > until #544674 is fixed. You will have to improve it. You missed earlier discussion, I do not know why Maitland push the issue over to you without the full discussion thread. If you look back in the history reverting the change will also break in other way. So in summary: you have to do system inspection because no DEB_*_ARCH / DEB_*_CPU will work on all combination of java package provider for libjawt.so I can understand that you would prefer another solution (I also personnaly do), but for the time being there is no convention for debian package providing libjawt.so and symlinks are not always provided. I'd really see VTK / ITK / Slicer / GDCM being considered for testing for such a small issue that is so deeply burried in cmake internals. cmake will soon be released so this patch will be integrated anyway. -- Mathieu -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
