Package: cryptmount Version: 1.1-2 Severity: serious Tags: patch User: initscripts-ng-de...@lists.alioth.debian.org Usertags: incorrect-dependency
With dependency based boot sequencing, I discovered what I believe is a bug in the init.d script. The scripts uses files in /usr/, but do not depend on $remote_fs. Also, the cryptmount-early script starts in rcS.d but depend on $syslog. This is an impossible dependency, as the syslog collector is started in runlevels 2-5 after rcS.d/ is complete. Finally, I suspect the cryptmount script expect the cryptmount-early script to run before it, and this relationship should be explicitly stated to make sure concurrent booting work as expected. <URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html > documents the LSB header format. Some debian notes are available from <URL: http://wiki.debian.org/LSBInitScripts >. This patch should fix the issues. Setting severity serious as the script will fail to work if /usr/ is on a separate partition, not yet mounted when the scripts are executed too early during boot. diff -ur cryptmount-4.0/initscript-early.in cryptmount-4.0-pere/initscript-early.in --- cryptmount-4.0/initscript-early.in 2009-05-04 08:07:28.000000000 +0200 +++ cryptmount-4.0-pere/initscript-early.in 2009-09-13 19:51:43.000000000 +0200 @@ -6,10 +6,8 @@ # Basic support for Linux Standard Base: ### BEGIN INIT INFO # Provides: cryptmount-early -# Required-Start: $syslog -# Required-Stop: $syslog -# Should-Start: $local_fs -# Should-Stop: $local_fs +# Required-Start: $remote_fs +# Required-Stop: $remote_fs # Default-Start: S # Default-Stop: 0 6 # Short-Description: setup encrypted devices at boot diff -ur cryptmount-4.0/initscript.in cryptmount-4.0-pere/initscript.in --- cryptmount-4.0/initscript.in 2009-05-04 08:07:28.000000000 +0200 +++ cryptmount-4.0-pere/initscript.in 2009-09-13 19:53:57.000000000 +0200 @@ -6,10 +6,8 @@ # Basic support for Linux Standard Base: ### BEGIN INIT INFO # Provides: cryptmount -# Required-Start: $syslog -# Required-Stop: $syslog -# Should-Start: $local_fs -# Should-Stop: $local_fs +# Required-Start: $remote_fs $syslog cryptmount-early +# Required-Stop: $remote_fs $syslog cryptmount-early # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: setup encrypted filesystems/swap at boot Happy hacking, -- Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
