tags 544463 + fixed-upstream thanks On Mon, Aug 31, 2009 at 07:51:36PM +0200, Patrick Matthäi wrote:
> And hello again, > > you are also shipping your own copy of GeoIP.dat: > > deluge-core: /usr/share/pyshared/deluge/data/GeoIP.dat > > This has got an non-free copyright notice: > m...@exez:~/build/deluge/deluge-1.1.9+dfsg$ strings deluge/data/GeoIP.dat > GEO-106FREE 20090601 Build 1 Copyright (c) 2007 MaxMind LLC > > This has been removed in the version of Debian, also it is more accurate. > > You should: > 1) Create a dfsg tarball and remove the file from the tarball > 2) Depend on geoip-database and symlink this file against: > /usr/share/GeoIP/GeoIP.dat Hi Patrick, thanks for your work on the geoip package (i've been reading the recent issue about building geoip-database from sources on lists) and thanks for this notification. As you can notice from the +dfsg suffix of the package and by reading the included README.source file, I tried hard to make the package dfsg-free without patching the source code by simply removing the 'All Rights Reserved' string from the binary database - the same as for geoip-database (<< 1.4.6.dfsg-8). This was done at the beginning of my packaging work (after the package adoption), and in the meanwhile I kept upstream up-to-date with this kind of issue, resulting in a patch[0] for the svn development version (upcoming 1.2) which removes GeoIP.dat from the sources and make it possible to use a database from a system wide installation. So I'm tagging this bug as fixed-upstream, and my intention is to actually try to backport the upstream svn patch to the latest stable release (1.1.9) instead of just having to wait for the new release to come. Any suggestion? [0] http://dev.deluge-torrent.org/changeset/5351 Thanks, -- Cristian Greco GPG key ID: 0x0C095825
signature.asc
Description: Digital signature
