Georges Khaznadar wrote: > please write at your choice one or two reasons why this is not cool.
Well, the biggest problem is that any changes you have made under wims/
are just destroyed. Why this is bad should be obvious.
Your trick can cause more subtle problems though - if the original
tarball is not found then an entirely different clean routine is used,
which leads to builds that are not easy to reproduce. This is compounded
by your brittle calculation of UPSTREAMVERSION which does not correctly
calculate the upstream version component in all cases (eg. binNMUs).
If it was such a great idea; why doesn't dpkg-buildpackage do it for all
packages? Anyway, the fix is fairly simple; just remove all the tarball
messing-about and expand your clean target to clean up after upstream.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org
`-
signature.asc
Description: PGP signature
