Hi, Thanks for your contribution to keeping Debian RC-bug-free; from a quick skim-read your patch looks like an improvement.
However, I'm not sure whether Debian really benefits enough from having bogosort to resolve this RC bug by fixing it rather than removing it: * without the -n option it's an implementation of a pathologically bad sorting algorithm (admittedly, this is deliberate) * GNU coreutils (which is Essential: yes) now has shuf(1), which shuffles lines like bogosort -n does * the build system is set up for autoconf 2.13 (!) * upstream's README says: "I wrote bogosort to learn a bit about automake and autoconf and because alsaplayer doesn't let me play files randomly". Debian has better (and less outdated) examples of autotools usage (notably, GNU hello is intended as an example), and shuf(1) covers the latter * it's had 5 uploads in 7.5 years, one of which was an NMU * popcon reports 92 installations and 10 votes So, perhaps it would be better to resolve this RC bug by removing bogosort from the distribution? On the other hand, I'd be willing to consider sponsoring your NMU if you can convince me that having bogosort is of benefit to Debian... Regards, Simon
signature.asc
Description: Digital signature