Package: gimp-gap Version: 2.6.0-1 Severity: serious Tags: patch Usertags: implicit-pointer-conversion
Our automated buildd log filter[1] detected a problem that is likely to cause your package to segfault on architectures where the size of a pointer is greater than the size of an integer, such as ia64 and amd64. Function `p_gtk_button_new_from_stock_icon' implicitly converted to pointer at gap_story_section_properties.c:869 Function `gap_fmac_get_alternate_name' implicitly converted to pointer at gap_story_properties.c:3340 Function `g_fopen' implicitly converted to pointer at gap_gve_misc_util.c:358 This is often due to a missing function prototype definition. For more information, see [2]. Though it is guaranteed that this codepath will cause a segfault on certain architectures, it is not guaranteed that this codepath would ever be executed (e.g., if the returned pointer is never dereferenced). However, this bug does prevent the ia64 buildd from successfully building this package, resulting in a practical FTBFS issue and warranting the serious severity. [1] http://people.debian.org/~dannf/check-implicit-pointer-functions [2] http://wiki.debian.org/ImplicitPointerConversions -- dann frazier
diff -urpN gimp-gap-2.6.0.orig/gap/gap_story_dialog.h gimp-gap-2.6.0/gap/gap_story_dialog.h --- gimp-gap-2.6.0.orig/gap/gap_story_dialog.h 2009-06-04 14:38:03.000000000 -0600 +++ gimp-gap-2.6.0/gap/gap_story_dialog.h 2009-07-10 13:30:35.833743151 -0600 @@ -32,6 +32,8 @@ #include "gap_story_main.h" #include "gap_story_properties.h" +GtkWidget * p_gtk_button_new_from_stock_icon(const char *stock_id); + void gap_storyboard_dialog(GapStbMainGlobalParams *gpp); void gap_story_dlg_attw_render_all(GapStbAttrWidget *attw); diff -urpN gimp-gap-2.6.0.orig/gap/gap_story_properties.c gimp-gap-2.6.0/gap/gap_story_properties.c --- gimp-gap-2.6.0.orig/gap/gap_story_properties.c 2009-06-04 14:38:03.000000000 -0600 +++ gimp-gap-2.6.0/gap/gap_story_properties.c 2009-07-10 13:31:59.424583981 -0600 @@ -55,6 +55,7 @@ #include "gap_timeconv.h" #include "gap_thumbnail.h" #include "gap_fmac_base.h" +#include "gap_fmac_name.h" #include "gap_story_vthumb.h" diff -urpN gimp-gap-2.6.0.orig/libgapvidutil/gap_gve_misc_util.c gimp-gap-2.6.0/libgapvidutil/gap_gve_misc_util.c --- gimp-gap-2.6.0.orig/libgapvidutil/gap_gve_misc_util.c 2009-06-04 14:38:03.000000000 -0600 +++ gimp-gap-2.6.0/libgapvidutil/gap_gve_misc_util.c 2009-07-10 13:33:22.379426254 -0600 @@ -34,6 +34,7 @@ #include <sys/stat.h> #include <errno.h> +#include <glib/gstdio.h> /* GIMP includes */ #include "gtk/gtk.h"
