Your message dated Thu, 02 Jul 2009 16:02:13 +0000
with message-id <e1mmojl-0001ay...@ries.debian.org>
and subject line Bug#535133: fixed in rasmol 2.7.4.2-5
has caused the Debian Bug report #535133,
regarding rasmol: basename implicitly converted to pointer
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
535133: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=535133
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: rasmol
Version: 2.7.4.2-4
Severity: serious
Tags: patch
Usertags: implicit-pointer-conversion
Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.
Function `basename' implicitly converted to pointer at molecule.c:338
Function `basename' implicitly converted to pointer at molecule.c:338
Function `basename' implicitly converted to pointer at molecule.c:338
Function `basename' implicitly converted to pointer at molecule.c:338
This is often due to a missing function prototype definition.
For more information, see [2].
Though it is guaranteed that this codepath will cause a segfault on certain
architectures, it is not guaranteed that this codepath would ever be executed
(e.g., if the returned pointer is never dereferenced). However, this bug
does prevent the ia64 buildd from successfully building this package, resulting
in a practical FTBFS issue and warranting the serious severity.
The attached patch assumes the GNU implementation of basename() is
desired. The same affect could be produced by adding -D_GNU_SOURCE to
the CFLAGS. If the POSIX basename semantics are preferred, you'll
probably want to #include <libgen.h> instead.
[1] http://people.debian.org/~dannf/check-implicit-pointer-functions
[2] http://wiki.debian.org/ImplicitPointerConversions
--
dann frazier
--- rasmol-2.7.4.2.orig/src/molecule.c 2009-06-29 19:23:18.000000000 -0600
+++ rasmol-2.7.4.2/src/molecule.c 2009-06-29 19:38:44.679559638 -0600
@@ -201,6 +201,7 @@
*/
+#define _GNU_SOURCE
#include "rasmol.h"
#ifdef IBMPC
--- End Message ---
--- Begin Message ---
Source: rasmol
Source-Version: 2.7.4.2-5
We believe that the bug you reported is fixed in the latest version of
rasmol, which is due to be installed in the Debian FTP archive:
rasmol-doc_2.7.4.2-5_all.deb
to pool/main/r/rasmol/rasmol-doc_2.7.4.2-5_all.deb
rasmol_2.7.4.2-5.diff.gz
to pool/main/r/rasmol/rasmol_2.7.4.2-5.diff.gz
rasmol_2.7.4.2-5.dsc
to pool/main/r/rasmol/rasmol_2.7.4.2-5.dsc
rasmol_2.7.4.2-5_i386.deb
to pool/main/r/rasmol/rasmol_2.7.4.2-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 535...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Teemu Ikonen <tpiko...@gmail.com> (supplier of updated rasmol package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 02 Jul 2009 15:39:45 +0200
Source: rasmol
Binary: rasmol rasmol-doc
Architecture: source i386 all
Version: 2.7.4.2-5
Distribution: unstable
Urgency: low
Maintainer: Debian Science Maintainers
<debian-science-maintain...@lists.alioth.debian.org>
Changed-By: Teemu Ikonen <tpiko...@gmail.com>
Description:
rasmol - Visualize biological macromolecules
rasmol-doc - Documentation for rasmol
Closes: 535133
Changes:
rasmol (2.7.4.2-5) unstable; urgency=low
.
* molecule.c: Add #define _GNU_SOURCE to get the correct definition
of basename() (closes: #535133)
Checksums-Sha1:
e1f9bd151321d79257cbe32d5acb94a27a71b097 1341 rasmol_2.7.4.2-5.dsc
6d789dce663f2d5705462e3b693b3d9334ab6ddc 39265 rasmol_2.7.4.2-5.diff.gz
57db3f03b8e1d2151faa2091f8284445409854d7 1287602 rasmol_2.7.4.2-5_i386.deb
a7fb05685d45bb3f62d516c60be603e4d95ed707 928856 rasmol-doc_2.7.4.2-5_all.deb
Checksums-Sha256:
b96d7ee7bbf1eff749d112b31563789c1c7c201d82851e56a9b450b4d7e03207 1341
rasmol_2.7.4.2-5.dsc
b60b7012f854573107460a2a4b3a2def26fb8b986c55907af8bf43b3d9cb4e21 39265
rasmol_2.7.4.2-5.diff.gz
715638681a9d5ce6b06d2f8cb18533954635ec5c5d39cfbd4838b53e54076677 1287602
rasmol_2.7.4.2-5_i386.deb
515d6633c3e3f53379adc9ef970bb54031b5e764751c253de6a8efe1e5b8c47a 928856
rasmol-doc_2.7.4.2-5_all.deb
Files:
c55d907969baa17d779a8c532e1c3a9e 1341 science optional rasmol_2.7.4.2-5.dsc
2ad1502d5b93b62775f1423d4ccfcf3b 39265 science optional
rasmol_2.7.4.2-5.diff.gz
946dd76f3cd0d4e8812e9650450945f5 1287602 science optional
rasmol_2.7.4.2-5_i386.deb
0ba3f0d025c59712206450f0831bf92f 928856 doc optional
rasmol-doc_2.7.4.2-5_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFKTNU1YDBbMcCf01oRAg7GAJ4oQTgr5BciwJEk+oobAZ4uDeaZjQCcCpJ1
lYc4v9UxhP5OSwZQYpcYt6I=
=8aYh
-----END PGP SIGNATURE-----
--- End Message ---
