tag 517568 pending thanks peter green <plugw...@p10link.net> (03/03/2009): > The fix is to change the two occourances of offset_t to int64_t in the > declaration of file_seek in ffmpeg.c (following the defintion in the > structure the function is used in)
Does the trick, thanks. Attached as real patch: motion-ftbfs.diff Also needed for me to get motion working: motion-segv.diff, which fixes a trivial segfault. Other occurrences of strcat() exist, but I guess upstream may want to fix them once for all, will try and remember to get in touch with them. I intend to NMU motion soon, no reply for several months, FTBFS everywhere, no maintainer reaction on this bug. Mraw, KiBi.
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -164,7 +164,7 @@
return write(fd, buf, size);
}
-static offset_t file_seek(URLContext *h, offset_t pos, int whence)
+static int64_t file_seek(URLContext *h, int64_t pos, int whence)
{
int fd = (size_t)h->priv_data;
return lseek(fd, pos, whence);
--- a/motion.c
+++ b/motion.c
@@ -2775,7 +2775,7 @@
#if (defined(BSD))
strerror_r(errno_save, buf + n, sizeof(buf) - n); /* 2 for the ': ' */
#else
- strcat(buf, strerror_r(errno_save, msg_buf, sizeof(msg_buf)));
+ strncat(buf, sizeof(buf) - n, strerror_r(errno_save, msg_buf, sizeof(msg_buf)));
#endif
}
/* If 'level' is not negative, send the message to the syslog */
signature.asc
Description: Digital signature
