Your message dated Tue, 24 Mar 2009 15:17:33 +0000
with message-id <e1lm8nh-0000rd...@ries.debian.org>
and subject line Bug#512463: fixed in netrek-client-cow 3.2.10-1
has caused the Debian Bug report #512463,
regarding netrek-client-cow: implicit-pointer-conversions
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
512463: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512463
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: netrek-client-cow
Version: 3.2.9-1
Severity: serious
Tags: patch
Usertags: implicit-pointer-conversion
Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.
Function `query_cowid' implicitly converted to pointer at newwin.c:1232
Function `getaddr2' implicitly converted to pointer at senddist.c:125
Function `query_cowid' implicitly converted to pointer at docwin.c:82
This is often due to a missing function prototype definition.
For more information, see [2].
Though it is guaranteed that this codepath will cause a segfault on certain
architectures, it is not guaranteed that this codepath would ever be executed
(e.g., if the returned pointer is never dereferenced). However, this bug
does prevent the ia64 buildd from successfully building this package, resulting
in a practical FTBFS issue and warranting the serious severity.
[1] http://people.debian.org/~dannf/check-implicit-pointer-functions
[2] http://wiki.debian.org/ImplicitPointerConversions
diff -urpN netrek-client-cow-3.2.9.orig/docwin.c netrek-client-cow-3.2.9/docwin.c
--- netrek-client-cow-3.2.9.orig/docwin.c 2009-01-05 01:17:39.000000000 -0700
+++ netrek-client-cow-3.2.9/docwin.c 2009-01-20 15:39:55.000000000 -0700
@@ -27,6 +27,7 @@
#include "data.h"
#include "packets.h"
+extern char *query_cowid(void);
/* #ifndef
* _IBMR2
* char
diff -urpN netrek-client-cow-3.2.9.orig/newwin.c netrek-client-cow-3.2.9/newwin.c
--- netrek-client-cow-3.2.9.orig/newwin.c 2009-01-05 01:17:43.000000000 -0700
+++ netrek-client-cow-3.2.9/newwin.c 2009-01-20 15:32:11.000000000 -0700
@@ -91,6 +91,7 @@ extern void waraction(W_Event * data);
/* Other function declarations */
extern int smessage(char ichar);
+extern char *query_cowid(void);
static int teamRequest(int team, int ship);
diff -urpN netrek-client-cow-3.2.9.orig/senddist.c netrek-client-cow-3.2.9/senddist.c
--- netrek-client-cow-3.2.9.orig/senddist.c 2009-01-05 01:17:39.000000000 -0700
+++ netrek-client-cow-3.2.9/senddist.c 2009-01-20 15:38:51.000000000 -0700
@@ -16,7 +16,7 @@
#include "struct.h"
#include "data.h"
-
+char *getaddr2(int flags, int recip);
/* this loads all sorts of useful data into a distress struct. */
struct distress *
--- End Message ---
--- Begin Message ---
Source: netrek-client-cow
Source-Version: 3.2.10-1
We believe that the bug you reported is fixed in the latest version of
netrek-client-cow, which is due to be installed in the Debian FTP archive:
netrek-client-cow_3.2.10-1.diff.gz
to pool/main/n/netrek-client-cow/netrek-client-cow_3.2.10-1.diff.gz
netrek-client-cow_3.2.10-1.dsc
to pool/main/n/netrek-client-cow/netrek-client-cow_3.2.10-1.dsc
netrek-client-cow_3.2.10-1_i386.deb
to pool/main/n/netrek-client-cow/netrek-client-cow_3.2.10-1_i386.deb
netrek-client-cow_3.2.10.orig.tar.gz
to pool/main/n/netrek-client-cow/netrek-client-cow_3.2.10.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 512...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Barry deFreese <bdefre...@debian.org> (supplier of updated netrek-client-cow
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 18 Mar 2009 10:17:31 -0400
Source: netrek-client-cow
Binary: netrek-client-cow
Architecture: source i386
Version: 3.2.10-1
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org>
Changed-By: Barry deFreese <bdefre...@debian.org>
Description:
netrek-client-cow - client for netrek online game
Closes: 512463
Changes:
netrek-client-cow (3.2.10-1) unstable; urgency=low
.
[ Barry deFreese ]
* Move maintainer to Debian Games Team. (It should have been anyway).
* New upstream release.
+ Fixes pointer coversions and other warnings. (Closes: #512463).
* Change make install call. Remove BINDIR, add prefix=/usr.
* Minor copyright syntax changes.
* Bump Standards Version to 3.8.1. (No changes needed).
Checksums-Sha1:
1e7b7bffd5bb72fc4d61abeabb73b224596d1561 1410 netrek-client-cow_3.2.10-1.dsc
4b06d6f0f3425cf8e9dfe896c4bc08b47dd2676f 632784
netrek-client-cow_3.2.10.orig.tar.gz
081e5dfdf47e08e69de0f93fd10016b76f9d7100 6330
netrek-client-cow_3.2.10-1.diff.gz
a2ab83501fc3b116ddc9698b00eb3a53d4a892b5 204166
netrek-client-cow_3.2.10-1_i386.deb
Checksums-Sha256:
6ac5a27cf6ff6a52b08c49183d1aa6e5af54bc5d8d6e12a943e9a30313c076c8 1410
netrek-client-cow_3.2.10-1.dsc
fa475e5a28f84f588f08f058b63eb5c424c602b52fc56c9202b0865213bd37b1 632784
netrek-client-cow_3.2.10.orig.tar.gz
d88c1c85d5c27a41ddc2262e4193a16d638e6868420d3e51d17d71319b33465f 6330
netrek-client-cow_3.2.10-1.diff.gz
677cfbd67d8636ef3dd907666506f97677efc24bac857b50da60147071e09771 204166
netrek-client-cow_3.2.10-1_i386.deb
Files:
8d37d8d893a3dde8408e84c00fbfcf9b 1410 games optional
netrek-client-cow_3.2.10-1.dsc
80bb2fdbd2454ba63304dccd6092ec1c 632784 games optional
netrek-client-cow_3.2.10.orig.tar.gz
59e900650687a04c8d6e1f6e2212c776 6330 games optional
netrek-client-cow_3.2.10-1.diff.gz
4a2617db7a1dc4e952a14c555cf1cf59 204166 games optional
netrek-client-cow_3.2.10-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAknI9cAACgkQ5ItltUs5T367KgCg66/sjvFND4kF5KlCtJWqbzuj
vVMAoJ3SlXuFjusKDXD/irHV5IfQoCyJ
=C59t
-----END PGP SIGNATURE-----
--- End Message ---
