Your message dated Sat, 21 Mar 2009 19:32:32 +0000
with message-id <e1ll6vo-0005ui...@ries.debian.org>
and subject line Bug#516204: fixed in xbindkeys-config 0.1.3-2
has caused the Debian Bug report #516204,
regarding xbindkeys-config: Gtk1.2 about to be removed from Debian [includes 
patch]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
516204: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=516204
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: xbindkeys-config
Version: 0.1.3-1
Severity: serious

Hi,

Gtk1.2 will not be shipping with Squeeze so xbindkeys-config will either
need to be ported to Gtk2 or removed from the archive.

I am attaching a debdiff that builds with Gtk2 as well as several other fixes. Seems to work fine with the minimal testing I did. Hope you can use it.

Thanks,

Barry deFreese
Debian QA




diff -u xbindkeys-config-0.1.3/Makefile xbindkeys-config-0.1.3/Makefile
--- xbindkeys-config-0.1.3/Makefile
+++ xbindkeys-config-0.1.3/Makefile
@@ -2,8 +2,8 @@
 
 CC=    gcc $(CFLAGS)
 STD=   _GNU_SOURCE
-GTK=   `gtk-config  --cflags --libs`
-GTK2=  `gtk-config  --cflags`
+GTK=   `pkg-config  --cflags --libs gtk+-2.0`
+GTK2=  `pkg-config  --cflags gtk+-2.0`
 OBJS=  xbindkeys_config.o menu.o middle.o speedc.o
 NOM=    xbindkeys_config
 
diff -u xbindkeys-config-0.1.3/middle.c xbindkeys-config-0.1.3/middle.c
--- xbindkeys-config-0.1.3/middle.c
+++ xbindkeys-config-0.1.3/middle.c
@@ -551,6 +551,8 @@
   GtkWidget *window;
   GtkWidget *text;
   GtkWidget *src;
+  GtkTextBuffer *textbuffer;
+  GtkTextIter iter;
   char line  [1024];
 
   unlink(TEMP_FILE); 
@@ -561,11 +563,13 @@
     gtk_window_set_title(GTK_WINDOW(window), "Generated File");
     src = gtk_scrolled_window_new ( NULL, NULL );
     gtk_widget_set_usize(src,500,400);
-    text = gtk_text_new (NULL, NULL);
+    text = gtk_text_view_new ();
+    textbuffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (text));
+    gtk_text_buffer_get_iter_at_offset (textbuffer, &iter, 0);
     gtk_container_add (GTK_CONTAINER(src),  text);
 
     while (fgets (line, sizeof(line), f))
-      gtk_text_insert (GTK_TEXT(text), NULL, NULL, NULL,
+      gtk_text_buffer_insert (textbuffer, &iter,
                       line, strlen(line));
 
     gtk_container_add(GTK_CONTAINER(window),src);
diff -u xbindkeys-config-0.1.3/debian/menu xbindkeys-config-0.1.3/debian/menu
--- xbindkeys-config-0.1.3/debian/menu
+++ xbindkeys-config-0.1.3/debian/menu
@@ -1,5 +1,5 @@
-?package(xbindkeys-config):needs=X11 \
-                          section=Apps/Tools \
+?package(xbindkeys-config):needs="X11" \
+                          section="Applications/System/Administration" \
                           title="XBindKeys-config" \
                           command="/usr/bin/xbindkeys-config" \
                           hints="Keys,Bind,Config" \
diff -u xbindkeys-config-0.1.3/debian/control 
xbindkeys-config-0.1.3/debian/control
--- xbindkeys-config-0.1.3/debian/control
+++ xbindkeys-config-0.1.3/debian/control
@@ -5,8 +5,8 @@
-Build-Depends: debhelper (>> 4.0.0), libgtk1.2-dev
-Standards-Version: 3.5.10
+Build-Depends: debhelper (>> 5.0.0), libgtk2.0-dev
+Standards-Version: 3.8.0
 
 Package: xbindkeys-config
 Architecture: any
 Depends: ${shlibs:Depends}, xbindkeys
-Description: An easy to use gtk program for configuring Xbindkeys.
- GTK Configure program for xbindkeys.
+Description: an easy to use gtk program for configuring Xbindkeys
+ GTK+ Configure program for xbindkeys.
diff -u xbindkeys-config-0.1.3/debian/rules xbindkeys-config-0.1.3/debian/rules
--- xbindkeys-config-0.1.3/debian/rules
+++ xbindkeys-config-0.1.3/debian/rules
@@ -1,14 +1,9 @@
 #!/usr/bin/make -f
 #export DH_VERBOSE=1
 
-# This is the debhelper compatibility version to use.
-export DH_COMPAT=4
-
 PACKAGE := xbindkeys-config
-pwd=$(shell pwd)
 
-TOPDIR := $(shell pwd)
-t = ${TOPDIR}/debian/xbindkeys-config
+t = $(CURDIR)/debian/xbindkeys-config
 
 DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
@@ -33,7 +28,7 @@
        dh_testdir
        dh_testroot
        rm -f build-stamp
-       -$(MAKE) clean
+       $(MAKE) clean
 
        dh_clean
 
diff -u xbindkeys-config-0.1.3/debian/changelog 
xbindkeys-config-0.1.3/debian/changelog
--- xbindkeys-config-0.1.3/debian/changelog
+++ xbindkeys-config-0.1.3/debian/changelog
@@ -1,3 +1,28 @@
+xbindkeys-config (0.1.3-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Build with Gtk2.
+    + Makefile: Use pkg-config instead of gtk-config.
+    + Change use of gtk_text with gtk_text_view.
+  * Rebuild to pickup newer X libs. (Closes: #367527).
+  * Lintian fixes: (Closes: #399774).
+    + Update FSF address in debian/copyright.
+    + Remove punctuation from short description.
+    + Quote strings in menu file.
+    + Thanks to Matti Pöllä for the fixes.
+  * Version path to GPL license in copyright.
+  * Add appropriate copyright holder to debian/copyright.
+  * Replace use of pwd with $(CURDIR) in rules.
+  * Replace GTK with GTK+ in description.
+  * Fix hyphen used as minus and what-is entry in manpage.
+  * Make clean not ignore errors.
+  * Bump debhelper build-dep to >> 5.0.0.
+    + Move DH_COMPAT from rules to debian/compat and set to 5.
+  * Bump Standards Version to 3.8.0.
+    + Menu policy transition.
+
+ -- Barry deFreese <bdefre...@debian.org>  Thu, 19 Feb 2009 13:25:57 -0500
+
 xbindkeys-config (0.1.3-1) unstable; urgency=low
 
   * New Upstream Release.
diff -u xbindkeys-config-0.1.3/debian/copyright 
xbindkeys-config-0.1.3/debian/copyright
--- xbindkeys-config-0.1.3/debian/copyright
+++ xbindkeys-config-0.1.3/debian/copyright
@@ -5,8 +5,9 @@
 
 Upstream Author: Laurent Vuibert <lapina...@gmx.fr>
 
-Copyright:
+Copyright: Copyright (C) 2002 by Laurent VUIBERT <lapina...@gmx.fr>
 
+License:
    This package is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; version 2 dated June, 1991.
@@ -20,7 +21,7 @@
    along with this package; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
-   02111-1307, USA.
+   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+   02110-1301, USA.
 
 On Debian GNU/Linux systems, the complete text of the GNU General
-Public License can be found in `/usr/share/common-licenses/GPL'.
+Public License can be found in `/usr/share/common-licenses/GPL-2'.
 
diff -u xbindkeys-config-0.1.3/debian/xbindkeys-config.1 
xbindkeys-config-0.1.3/debian/xbindkeys-config.1
--- xbindkeys-config-0.1.3/debian/xbindkeys-config.1
+++ xbindkeys-config-0.1.3/debian/xbindkeys-config.1
@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.27.
 .TH XBINDKEYS_CONFIG "1" "April 2002" "xbindkeys-config" "User Commands"
 .SH NAME
-xbindkeys_config \- manual page for xbindkeys_config
+xbindkeys-config \- GTK+ configuration tool for xbindkeys
 .SH "SYNOPSIS"
 xbindkeys-config 
-[--file|-f file]
-[--help|-h]
-[--show|-s]
+[\-\-file|\-f file]
+[\-\-help|\-h]
+[\-\-show|\-s]
 .TP
 \fB\-h\fR, \fB\-\-help\fR
 This Help
only in patch2:
unchanged:
--- xbindkeys-config-0.1.3.orig/xbindkeys_config.c
+++ xbindkeys-config-0.1.3/xbindkeys_config.c
@@ -95,7 +95,8 @@
      accel_group = gtk_accel_group_new();
      menu=xbindkeys_config_menu(accel_group);
      gtk_box_pack_start(GTK_BOX(vbox),menu,FALSE,FALSE,0);
-     gtk_accel_group_attach(accel_group, GTK_OBJECT(window));
+/* BDD - FIXME - Don't need this? */
+/*     gtk_accel_group_attach(accel_group, GTK_OBJECT(window)); */
      
      middle= xbindkeys_config_middle();
      gtk_box_pack_start(GTK_BOX(vbox),middle,TRUE,TRUE,0);
only in patch2:
unchanged:
--- xbindkeys-config-0.1.3.orig/menu.c
+++ xbindkeys-config-0.1.3/menu.c
@@ -283,6 +283,8 @@
   GtkWidget *window;
   GtkWidget *text;
   GtkWidget *vbox;
+  GtkTextBuffer *textbuffer;
+  GtkTextIter iter;
   
   window = gtk_window_new( GTK_WINDOW_TOPLEVEL );
   gtk_window_set_title(GTK_WINDOW(window),
@@ -293,10 +295,13 @@
   text = gtk_label_new("\nManual\n");
   gtk_box_pack_start(GTK_BOX(vbox), text, FALSE, FALSE, 0);
   
-  text = gtk_text_new(NULL,NULL);
+/* BDD - FIXME */
+/*  text = gtk_text_new(NULL,NULL); */
+  text = gtk_text_view_new();
+  textbuffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (text));
+  gtk_text_buffer_get_iter_at_offset (textbuffer, &iter, 0);
   
-  
-  gtk_text_insert (GTK_TEXT(text), NULL, NULL, NULL,
+  gtk_text_buffer_insert (textbuffer, &iter, 
                   MANUAL_TEXT, sizeof(MANUAL_TEXT)-1);
   gtk_box_pack_start(GTK_BOX(vbox), text, TRUE, TRUE, 0);
   gtk_widget_set_usize(text,300,250);
only in patch2:
unchanged:
--- xbindkeys-config-0.1.3.orig/debian/compat
+++ xbindkeys-config-0.1.3/debian/compat
@@ -0,0 +1 @@
+5


--- End Message ---
--- Begin Message ---
Source: xbindkeys-config
Source-Version: 0.1.3-2

We believe that the bug you reported is fixed in the latest version of
xbindkeys-config, which is due to be installed in the Debian FTP archive:

xbindkeys-config_0.1.3-2.diff.gz
  to pool/main/x/xbindkeys-config/xbindkeys-config_0.1.3-2.diff.gz
xbindkeys-config_0.1.3-2.dsc
  to pool/main/x/xbindkeys-config/xbindkeys-config_0.1.3-2.dsc
xbindkeys-config_0.1.3-2_amd64.deb
  to pool/main/x/xbindkeys-config/xbindkeys-config_0.1.3-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 516...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joerg Jaspert <jo...@debian.org> (supplier of updated xbindkeys-config package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 21 Mar 2009 19:46:17 +0100
Source: xbindkeys-config
Binary: xbindkeys-config
Architecture: source amd64
Version: 0.1.3-2
Distribution: unstable
Urgency: low
Maintainer: Joerg Jaspert <jo...@debian.org>
Changed-By: Joerg Jaspert <jo...@debian.org>
Description: 
 xbindkeys-config - an easy to use gtk program for configuring Xbindkeys
Closes: 367527 399774 449787 516204
Changes: 
 xbindkeys-config (0.1.3-2) unstable; urgency=low
 .
   * Upload based *heavily* on work from Barry. Thanks!
   * Bug fix: "Gtk1.2 about to be removed from Debian [includes patch]",
     thanks to bdefre...@debian.org (Closes: #516204).
   * Build with Gtk2.
     + Makefile: Use pkg-config instead of gtk-config.
     + Change use of gtk_text with gtk_text_view.
   * Rebuild to pickup newer X libs. (Closes: #367527).
   * Lintian fixes: (Closes: #399774).
     + Update FSF address in debian/copyright.
     + Remove punctuation from short description.
     + Quote strings in menu file.
     + Thanks to Matti Pöllä for the fixes.
   * Version path to GPL license in copyright.
   * Add appropriate copyright holder to debian/copyright.
   * Replace use of pwd with $(CURDIR) in rules.
   * Replace GTK with GTK+ in description.
   * Fix hyphen used as minus and what-is entry in manpage.
   * Make clean not ignore errors.
   * Bump debhelper build-dep to >> 5.0.0.
     + Move DH_COMPAT from rules to debian/compat and set to 5.
   * Bump Standards Version to 3.8.0.
     + Menu policy transition.
   * Removed watchfile, to fix: "debian/watch fails to report
     upstreams version", thanks to Raphael Geissert (Closes: #449787).
Checksums-Sha1: 
 95cd0bfb0bee96b80e77af80d02d9fd11b10517b 1090 xbindkeys-config_0.1.3-2.dsc
 7a2cd3253f4d1438264dfb5d13b8c22413b093a2 3712 xbindkeys-config_0.1.3-2.diff.gz
 5357de07121c6f4abc403fd9fb64734e4ba84798 20640 
xbindkeys-config_0.1.3-2_amd64.deb
Checksums-Sha256: 
 a3a73ca7ff077b7002e4d81d005bc28f6e7bf8c59a20928780078a689150f695 1090 
xbindkeys-config_0.1.3-2.dsc
 47b0e01d8b3eb1b748968186c0f7074b813609848a1f5e9bf828e4075da326ee 3712 
xbindkeys-config_0.1.3-2.diff.gz
 f97985fd4a0a6e65150605610b9902f8be9aa0ef726f8a49134a4a7ad7f0cdd6 20640 
xbindkeys-config_0.1.3-2_amd64.deb
Files: 
 57a6a08dae7d3bfea1ec368555ff4914 1090 x11 optional xbindkeys-config_0.1.3-2.dsc
 7036aeef8276796ebdc04dc6b9bfd914 3712 x11 optional 
xbindkeys-config_0.1.3-2.diff.gz
 149d6e0faf44e3b9b6591467e1e70ce5 20640 x11 optional 
xbindkeys-config_0.1.3-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Joerg Jaspert <jo...@debian.org> -- Debian Developer

iEYEARECAAYFAknFPbQACgkQcV7WoH57islxvQCeL5WHDxhM+gDqdyiAJ8WqnmOc
2ZIAn3Co8NFzD0T60lVfc1u1h1/1/6LC
=Ss8b
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to