On Tue, Mar 17, 2009 at 09:27:33PM -0600, dann frazier wrote: > On Wed, Mar 18, 2009 at 12:49:49PM +1100, Trent W. Buck wrote: >> On Tue, Mar 17, 2009 at 06:57:24PM -0600, dann frazier wrote: >>> I tested the initial patch on paer.debian.org, a parisc machine. >>> I found that it didn't work. However, this one did: >>> >>> - ./waf --nocache configure --prefix=/usr >>> + CFLAGS="-fPIC" ./waf --nocache configure --prefix=/usr >> >> Yes, but the submitter mentioned that >> >> >> [upstream prefers] to add a check for parisc instead making >> >> libgkatze .so or adding -fPIC unconditional. > > I provided sample code for doing so which you trimmed in your reply.
Sorry, I was thinking that upstream objected to -fPIC *at all*. >> Since no rationale was given, I am reluctant to do this without >> discussing it with upstream. BTW, I would change that to >> >> CFLAGS += -fPIC >> >> at the top of the makefile (otherwise it would eat -O2 -Wall and >> similar). > > Also in the sample code I provided. Oops, I misread that part, too. I thought both versions has = not +=. >> DEB_HOST_ARCH := $(shell dpkg-architecture -qDEB_HOST_ARCH) >> ifeq ($(DEB_HOST_ARCH),hppa) >> CFLAGS+="-fPIC" >> endif -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
