Package: midori
Version: 0.1.2-1
Severity: serious
Tags: patch

midori fails to compile hppa [1].
The patch attached could help, I have no access to hppa box to say this
for sure :)
I talked to upstream and it is prefered to add a check for parisc
instead making libgkatze .so or adding -fPIC unconditional. Sould
someone test or test-build it?

[1]
https://buildd.debian.org/fetch.cgi?&pkg=midori&ver=0.1.2-1&arch=hppa&stamp=1234726742&file=log

Sebastian
>From b7767200c69be8720d0efdc898c818a4557a53c7 Mon Sep 17 00:00:00 2001
From: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
Date: Wed, 4 Mar 2009 22:02:58 +0100
Subject: [PATCH] Always use -fPIC in libkatze

in the midori build:
- libkatze is compiled as a static library
- addons / extensions is compiled as a shared library

The extensions have to be build as .so and loaded at runtime. libkatze is
required by midori and should be built-in. Some of the extensions need symbols
which are exported by libkatze so we have to make libkatze -fPIC _or_ make a
.so as well.

Signed-off-by: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
---
 katze/wscript_build  |    3 +++
 midori/wscript_build |    6 ++++++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/katze/wscript_build b/katze/wscript_build
index 128fd35..4ee3c52 100644
--- a/katze/wscript_build
+++ b/katze/wscript_build
@@ -14,3 +14,6 @@ obj.install_path = None
 
 if platform.architecture ()[0] == '64bit':
     obj.env.append_value ('CCFLAGS', '-fPIC')
+
+if platform.machine() == 'parisc':
+    obj.env.append_value ('CCFLAGS', '-fPIC')
diff --git a/midori/wscript_build b/midori/wscript_build
index 91f5302..adee630 100644
--- a/midori/wscript_build
+++ b/midori/wscript_build
@@ -17,6 +17,9 @@ obj.install_path = None
 if platform.architecture ()[0] == '64bit':
     obj.env.append_value ('CCFLAGS', '-fPIC')
 
+if platform.machine() == 'parisc':
+    obj.env.append_value ('CCFLAGS', '-fPIC')
+
 obj = bld.new_task_gen ('cc', 'staticlib')
 obj.name = 'panels'
 obj.target = 'panels'
@@ -29,6 +32,9 @@ obj.install_path = None
 if platform.architecture ()[0] == '64bit':
     obj.env.append_value ('CCFLAGS', '-fPIC')
 
+if platform.machine() == 'parisc':
+    obj.env.append_value ('CCFLAGS', '-fPIC')
+
 obj = bld.new_task_gen ('cc', 'program')
 obj.target = 'midori'
 obj.includes = '. .. ../panels'
-- 
1.6.1.3

Reply via email to