tags 516669 + patch
quit
On Mon, Feb 23, 2009 at 12:43:39AM +0100, Peter Palfrader wrote:
> Files in /usr/share/git-core are not owned by root on lenny/alpha.
Thanks for catching this. Here's a patch for stable, unstable already
contains the fix, although there seems to be another similar permissions
problem I'm investigating right now.
The bug only has an impact if the package is build with -rsudo, the
files are properly owned by root with -rfakeroot. The alpha, mips, and
mipsel autobuilders seem to use -rsudo.
t...@security, if there's anything more I can do, such as providing a
signed package for stable, please let me know.
Regards, Gerrit.
commit 24aaa9dc0b99ebe01b190dc1d97a24d5b4616abd
Author: Gerrit Pape <p...@smarden.org>
Date: Mon Feb 23 14:00:16 2009 +0000
* debian/diff/0006-Install-templates-with-the-user-and-group...diff:
new, cherry-picked from 71f4637: Install templates with the user and
group of the installing personality (closes: #516669).
diff --git a/debian/changelog b/debian/changelog
index 44ede58..57712eb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+git-core (1:1.5.6.5-4) stable-security; urgency=high
+
+ * debian/diff/0006-Install-templates-with-the-user-and-group...diff:
+ new, cherry-picked from 71f4637: Install templates with the user and
+ group of the installing personality (closes: #516669).
+
+ -- Gerrit Pape <p...@smarden.org> Mon, 23 Feb 2009 13:50:14 +0000
+
git-core (1:1.5.6.5-3) unstable; urgency=high
* debian/rules: no longer install symlink /etc/init.d/git-daemon ->
diff --git
a/debian/diff/0006-Install-templates-with-the-user-and-group-of-the-inst.diff
b/debian/diff/0006-Install-templates-with-the-user-and-group-of-the-inst.diff
new file mode 100644
index 0000000..786b0b9
--- /dev/null
+++
b/debian/diff/0006-Install-templates-with-the-user-and-group-of-the-inst.diff
@@ -0,0 +1,34 @@
+From e37aa693898859df1f44a79bdf85232c9c4c6d87 Mon Sep 17 00:00:00 2001
+From: Gerrit Pape <p...@smarden.org>
+Date: Mon, 23 Feb 2009 13:49:00 +0000
+Subject: [PATCH] Install templates with the user and group of the installing
personality
+
+If 'make install' was run with sufficient privileges, then the installed
+templates, which are copied using 'tar', would receive the user and group
+of whoever built git. This instructs 'tar' to ignore the user and group
+that are recorded in the archive.
+
+Signed-off-by: Johannes Sixt <johannes.s...@telecom.at>
+Signed-off-by: Junio C Hamano <gits...@pobox.com>
+(cherry picked from commit 71f463773a310de016da20136fd7160685f97faa)
+
+Conflicts:
+
+ templates/Makefile
+---
+ templates/Makefile | 2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/templates/Makefile b/templates/Makefile
+index bda9d13..94cd8f4 100644
+--- a/templates/Makefile
++++ b/templates/Makefile
+@@ -48,4 +48,4 @@ clean:
+ install: all
+ $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(template_dir_SQ)'
+ (cd blt && $(TAR) cf - .) | \
+- (cd '$(DESTDIR_SQ)$(template_dir_SQ)' && umask 022 && $(TAR) xf -)
++ (cd '$(DESTDIR_SQ)$(template_dir_SQ)' && umask 022 && $(TAR) xfo -)
+--
+1.6.1.3
+
