Your message dated Sat, 16 Jul 2005 19:02:28 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#318527: fixed in atanks 1.1.0-4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 16 Jul 2005 01:40:21 +0000
>From [EMAIL PROTECTED] Fri Jul 15 18:40:20 2005
Return-path: <[EMAIL PROTECTED]>
Received: from zoot.lafn.org [206.117.18.6]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1DtbfA-0004Yy-00; Fri, 15 Jul 2005 18:40:20 -0700
Received: from localhost.localdomain
(pool-71-104-165-253.lsanca.dsl-w.verizon.net [71.104.165.253])
(authenticated bits=0)
by zoot.lafn.org (8.13.1/8.13.1) with ESMTP id j6G1eJDx023451
(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO)
for <[EMAIL PROTECTED]>; Fri, 15 Jul 2005 18:40:20 -0700 (PDT)
(envelope-from [EMAIL PROTECTED])
Received: from kraai by localhost.localdomain with local (Exim 4.50)
id 1DtS1j-0000rO-NQ
for [EMAIL PROTECTED]; Fri, 15 Jul 2005 08:22:59 -0700
Date: Fri, 15 Jul 2005 08:22:59 -0700
From: Matt Kraai <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: FTBFS: Ambiguous calls of abs(double)
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="wchHw8dVAp53YPj8"
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
X-Virus-Scanned: ClamAV version 0.85.1, clamav-milter version 0.85 on
zoot.lafn.org
X-Virus-Status: Clean
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-2.4 required=4.0 tests=BAYES_00,DATE_IN_PAST_06_12
autolearn=no version=2.60-bugs.debian.org_2005_01_02
--wchHw8dVAp53YPj8
Content-Type: multipart/mixed; boundary="BRE3mIcgqKzpedwo"
Content-Disposition: inline
--BRE3mIcgqKzpedwo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: atanks
Version: 1.1.0-3
Severity: serious
atanks fails to build because it contains some ambiguous calls to abs
on doubles (among other problems):
g++ -c player.cc -o player.o -DLINUX -DVERSION=3D\"1.1.0\" -DDATA_DIR=3D\"/=
usr/share/games/atanks\" -O2 -fsigned-char -Wall -Iinclude -g
player.cc: In member function 'int PLAYER::addTankDamageToMatrix(TANK*, TAN=
K*, int)':
player.cc:1012: error: call of overloaded 'abs(double)' is ambiguous
/usr/include/stdlib.h:748: note: candidates are: int abs(int)
/usr/lib/gcc/i486-linux-gnu/4.0.1/../../../../include/c++/4.0.1/cstdlib:169=
: note: long long int __gnu_cxx::abs(long long int)
/usr/lib/gcc/i486-linux-gnu/4.0.1/../../../../include/c++/4.0.1/cstdlib:130=
: note: long int std::abs(long int)
player.cc:1017: error: call of overloaded 'abs(double)' is ambiguous
/usr/include/stdlib.h:748: note: candidates are: int abs(int)
/usr/lib/gcc/i486-linux-gnu/4.0.1/../../../../include/c++/4.0.1/cstdlib:169=
: note: long long int __gnu_cxx::abs(long long int)
/usr/lib/gcc/i486-linux-gnu/4.0.1/../../../../include/c++/4.0.1/cstdlib:130=
: note: long int std::abs(long int)
player.cc: In member function 'void PLAYER::calcDamageMatrix(TANK*, int)':
player.cc:1088: error: call of overloaded 'abs(double)' is ambiguous
/usr/include/stdlib.h:748: note: candidates are: int abs(int)
/usr/lib/gcc/i486-linux-gnu/4.0.1/../../../../include/c++/4.0.1/cstdlib:169=
: note: long long int __gnu_cxx::abs(long long int)
/usr/lib/gcc/i486-linux-gnu/4.0.1/../../../../include/c++/4.0.1/cstdlib:130=
: note: long int std::abs(long int)
make[2]: *** [player.o] Error 1
make[2]: Leaving directory `/tmp/buildd/atanks-1.1.0/src'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/buildd/atanks-1.1.0'
make: *** [build-stamp] Error 2
The attached patch fixes these problems.
--=20
Matt
--BRE3mIcgqKzpedwo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
Content-Transfer-Encoding: quoted-printable
only in patch2:
unchanged:
--- atanks-1.1.0.orig/src/player.cc
+++ atanks-1.1.0/src/player.cc
@@ -1009,12 +1009,12 @@
if (weapNum >=3D RIOT_CHARGE && weapNum <=3D RIOT_BLAST) {
// add points only within range and above ctank
if ( (cy > ctank->y - (radius / 2)) ||
- (abs (ctank->x - cx) > radius))
+ (fabs (ctank->x - cx) > radius))
continue;
} else if (weapNum >=3D SML_ROLLER && weapNum <=3D DTH_ROLLER) {
// Only aim rollers above other tanks
if (cy > tankY + TANKHEIGHT &&
- abs (ctank->x - cx) > radius)
+ fabs (ctank->x - cx) > radius)
continue;
} else if (weapNum >=3D SML_LAZER && weapNum <=3D LRG_LAZER) {
// Lazer can only be aimed above horizontal
@@ -1085,7 +1085,7 @@
if (itemNum >=3D ITEM_VENGEANCE && itemNum <=3D
ITEM_FATAL_FURY) {
// add sqrt distances for each tank * potential
damage
long int totalEffectiveDamage =3D
calcTotalEffectiveDamage (itemNum);
- _targetMatrix[(int)ctank->x] +=3D sqrt (abs
(ctank->x - ltank->x)) * t=
otalEffectiveDamage;
+ _targetMatrix[(int)ctank->x] +=3D sqrt (fabs
(ctank->x - ltank->x)) * =
totalEffectiveDamage;
=20
}
}
--BRE3mIcgqKzpedwo--
--wchHw8dVAp53YPj8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFC19TTfNdgYxVXvBARAogZAJ9/QUHSc7rJCx06w0IDc51QtnhYfQCfXFLg
sVwcGSopPkGDHcRMEx2I3vA=
=wmS+
-----END PGP SIGNATURE-----
--wchHw8dVAp53YPj8--
---------------------------------------
Received: (at 318527-close) by bugs.debian.org; 16 Jul 2005 23:16:32 +0000
>From [EMAIL PROTECTED] Sat Jul 16 16:16:31 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1DtvtX-0002Yv-00; Sat, 16 Jul 2005 16:16:31 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1Dtvfw-0003S0-00; Sat, 16 Jul 2005 19:02:28 -0400
From: Graham Wilson <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#318527: fixed in atanks 1.1.0-4
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sat, 16 Jul 2005 19:02:28 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2
Source: atanks
Source-Version: 1.1.0-4
We believe that the bug you reported is fixed in the latest version of
atanks, which is due to be installed in the Debian FTP archive:
atanks-data_1.1.0-4_all.deb
to pool/main/a/atanks/atanks-data_1.1.0-4_all.deb
atanks_1.1.0-4.diff.gz
to pool/main/a/atanks/atanks_1.1.0-4.diff.gz
atanks_1.1.0-4.dsc
to pool/main/a/atanks/atanks_1.1.0-4.dsc
atanks_1.1.0-4_i386.deb
to pool/main/a/atanks/atanks_1.1.0-4_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Graham Wilson <[EMAIL PROTECTED]> (supplier of updated atanks package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 16 Jul 2005 22:39:13 +0000
Source: atanks
Binary: atanks-data atanks
Architecture: source i386 all
Version: 1.1.0-4
Distribution: unstable
Urgency: low
Maintainer: Graham Wilson <[EMAIL PROTECTED]>
Changed-By: Graham Wilson <[EMAIL PROTECTED]>
Description:
atanks - tank-battling game
atanks-data - data files for Atomic tanks
Closes: 290061 318527
Changes:
atanks (1.1.0-4) unstable; urgency=low
.
* Include copyright information in copyright file. (closes: #290061)
* Remove the watch file, since it currently is broken. It'd be
appreciated if someone can send me a working one.
* Use int where the code was using char as a boolean value.
- cuts down on the number of compiler warnings
- no need to compile with -fsigned-char
* Use fabs where abs was ambiguous. (closes: #318527)
* Update standards version. No changes.
Files:
be73201f3b9210f8099777a91515fe8c 877 games optional atanks_1.1.0-4.dsc
0da9c1e656ae999fcf9cbff6f4765e97 6567 games optional atanks_1.1.0-4.diff.gz
a9665320844090a7b12a652a9c37cdd8 986290 games optional
atanks-data_1.1.0-4_all.deb
6f8b9d15ce2653887dcc9e84739ad71a 93356 games optional atanks_1.1.0-4_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iQEVAwUBQtmQFS6fnYH5E4SWAQJ9CggAqEPKVQImCVoBmAXrExjRcCbx8MunRN+S
H0nvh8cVxEHE07kp+q4chK33FspscOITZ/ZU4yoQyUQCG5kgD8pgUM/LiEThOUCs
NyJRZI/zDzrX1u3KeCG86THcQQoldVtvE9Dx3WmQ2D8toKI5ynNEjr+6y4DNYMsk
/7WuvtCQJ/tAxbezdHKbxlgYNCGNIXWhkjXMllimlXe+E81xApRehj3mpCxyXAoT
ncejGfe8b75xAUuMLfSRdbOMGnZ3paqLumpp5ATBDZ57sW9p/55SG8CdlHc91dnb
jcrqLr+NVJuc42r9aQca6gw2epuKCydb32Ozz7+CJVnzzq5WKR5Ekw==
=hH8J
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
