On Thu, Jan 15, 2009 at 2:44 PM, Pierre Habouzit <madco...@debian.org> wrote: > # and to be frank I believe this bug is just plain invalid > severity 511687 normal > thanks
No the bug is not really invalid it shoke insserver because git-daemon-run is a binary file, it does not crash but report loundly that it can not read the file git-daemon-run. Ok it is not a bug per se, but admin could personnalize init.d script. > On Tue, Jan 13, 2009 at 02:06:36PM +0000, Bastien ROUCARIES wrote: >> Package: git-daemon-run >> Version: 1:1.5.6.5-2 >> Severity: serious >> >> Seveirty serious because it is a policy violation: according to section 9.3 >> of debian policy. >> >> Please add a script, and document correctly dependancy using >> http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot >> >> Regards > > No it doesn't _need_ to, the very standard way to use git-daemon is > usually through a super-server. git-daemon-run is just a way to enable > git-daemon into runit, which is the packager choice and has nothing to > do with the policy as-is. Yes but put a symlink to a binary file in /etc/init.d is not really nice. According to section 9.3, /etc/init.d MUST be script. symlink is bad usage at least. > git-daemon is part of git-core and it would make really no sense to > enable git-daemon as an init script part of this package. > As an example, I serve git-daemon through xinetd on my server, and I > just had to write this: > > $ cat /etc/xinetd.d/git-daemon > # description: The git server offers access to git repositories > service git > { > disable = no > type = UNLISTED > port = 9418 > socket_type = stream > wait = no > user = nobody > server = /usr/bin/git-daemon > flags = IPv6 > server_args = --inetd --export-all --base-path=/git/public > --user-path=public_git > log_on_failure += USERID > } > > Arguably the packager could document this or a way to enable git-daemon > through > the usual inetd servers, but that's it IMNSHO. Ok I agree and rename git-daemon-run to git-daemon-runit And according to man page git-daemon could be run as a stand alone daemon: >git-daemon as regular daemon for virtual hosts > To set up git-daemon as a regular, non-inetd service that handles > repositories for multiple virtual hosts based on their IP >addresses, start > the daemon like this: > git-daemon --verbose --export-all > --interpolated-path=/pub/%IP/%D > /pub/192.168.1.200/software > /pub/10.10.220.23/software > In this example, the root-level directory /pub will contain a > subdirectory for each virtual host IP address supported. >Repositories can > still be accessed by > hostname though, assuming they correspond to these IP addresses. I believe that this package provide the standalone daemon because it wrote to /etc/init.d :( Regards Bastien -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
