tags 318003 patch
thanks
Hi,
On Wed, Jul 13, 2005 at 11:49:57AM -0700, [EMAIL PROTECTED] wrote:
> ok that's progress at least.
> i don't understand how it's failing though.
> what do you see if you run it from the command line?
a window opened but never get refreshed (as if it was in sleep mode).
nothing was printed on the console.
today i upgraded to the latest xlibs that comes along xorg-x11, and this
behaviour went away. i can now see the movie fine, and the screensaver
works as expected. beautiful.
i am not really up to downgrade xlibs and co, but i guess the problem is
reproducible on a current testing install.
for now this bug can probably be closed when the attached patch gets in.
> what do you get form "electricsheep --debug 1"?
now it's working, i get this:
$ electricsheep --debug 1
decoder execvp mpeg2dec_onroot -f 23 -w -1
found new anim id=13215.
play anim x=7 id=13215 iters=1.
history = 13215
succ x=2 id=9910 h=300
lsucc to 9910, lnsuccs=1.
play anim x=2 id=9910 iters=2.
history = 9910 13215
handle_sig_term display 2
cleanup.
handle_sig_term main 15
handle_sig_term display 15
handle_sig_term download 15
cleanup.
cleanup.
cleanup.
Terminated
> what differences are you aware between the bundled mpeg2lib
> and debian's?
from the README file in electricsheep/mpeg2dec, i thought you would
know! :-) the version shipped with electricsheep is 0.2.1, the version
currently in debian is 0.4.0b. the diffs are quit large, below are the
relevant changelog entries.
diff -ruNad electricsheep-2.6.2/mpeg2dec/ChangeLog mpeg2dec-0.4.0b/ChangeLog
--- electricsheep-2.6.2/mpeg2dec/ChangeLog 2004-12-15 07:21:33.000000000
+0000
+++ mpeg2dec-0.4.0b/ChangeLog 2003-12-23 11:51:16.000000000 +0000
@@ -1,3 +1,26 @@
+mpeg2dec-0.4.0 Tue Dec 23 03:04:35 PST 2003
+-support for 4:2:2-profile streams as well as 4:4:4 format
+-extra robustness with extensive test framework (including bad streams etc)
+-support for concatenated streams
+-helper library for common color conversion formats (currently rgb and uyvy)
+-sparc VIS MC optimizations from David Miller
+-new set-stride and decoder-reset functions
+-some code samples for (very basic) documentation
+
+mpeg2dec-0.3.1 Fri Dec 13 22:15:36 PST 2002
+-integrated CPU detection code
+-alpha IDCT/MC optimizations
+-C IDCT optimizations
+-fixed all known memory leaks
+-workarounds for HPPA/IA64/sparc build issues
+
+mpeg2dec-0.3.0 Wed Nov 27 23:23:23 PST 2002
+-first release using the new libmpeg2 API
+-improved error handling - does not seek to the next sequence header anymore
+-more minor optimizations (about 7% faster than 0.2.1)
+-support for streams higher than 2800 pixels
+-added SIMD optimizations to the VC++ port
+
mpeg2dec-0.2.1 Sun Mar 17 23:24:04 PST 2002
-altivec optimizations - provides 2.5x speedup for g4 processors
-fixed MC code - should not crash on bad streams anymore
cheers, piem
diff -ruNad electricsheep-2.6.2/electricsheep.c
elec/electricsheep-2.6.2/electricsheep.c
--- electricsheep-2.6.2/electricsheep.c 2005-06-06 22:51:32.000000000 +0100
+++ elec/electricsheep-2.6.2/electricsheep.c 2005-07-14 09:38:55.000000000
+0100
@@ -1655,8 +1655,8 @@
void
flags_init(int *argc, char ***argv) {
char *arg0 = (*argv)[0];
- char *bracket_begin;
- char *bracket_end;
+ char *bracket_begin = 0;
+ char *bracket_end = 0;
while (*argc > 1 &&
(*argv)[1][0] == '-') {
char *o = (*argv)[1];
