Package: python-rfxswf
Version: 0.8.1-2
Severity: grave
Tags: patch

Hi Simo,

unfortunately, it seems that python-rfxswf needs quite a bit of fixup to be
installable and usable.
The attached makes it build for the relevant python versions (i.e.
including python2.5). This in turn makes it actually installable. Also
you need to not link modules against libpython because you don't want
that and in order to not incur dependencies on python2.4 and
python2.5. This you might also want to tell upstream. Finally, you
need to call dh_installdeb to have the pysupport-generated
maintainerscripts installed. With the attached patch, stuff is
correctly build, the dependencies look saner, and "import SWF"
actually works.

I should strongly advise to install all packages and minimally test
them (i.e. quickly start programs, do some things; import the python
module, do some things with it) before uploading them / asking a sponsor to
upload.

I have spoken with Barry, your last sponsor, who said he'll have
additional fixes for you, so we agreed to have him incorporate these
as well.

Happy holidays and kind regards

T.

diff -u swftools-0.8.1/debian/python-rfxswf.install 
swftools-0.8.1/debian/python-rfxswf.install
--- swftools-0.8.1/debian/python-rfxswf.install
+++ swftools-0.8.1/debian/python-rfxswf.install
@@ -1 +1 @@
-usr/lib/python2.4/site-packages/SWF.so
+usr/lib/python*/site-packages/SWF.so
diff -u swftools-0.8.1/debian/rules swftools-0.8.1/debian/rules
--- swftools-0.8.1/debian/rules
+++ swftools-0.8.1/debian/rules
@@ -14,14 +14,7 @@
 DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 
-PYTHON_MAJOR_VERSIONS = 2
-PYTHON_MINOR_VERSIONS = 4
-PYTHON_VERSION = $(PYTHON_MAJOR).$(PYTHON_MINOR)
-python_targets = $(foreach PYTHON_MAJOR, $(PYTHON_MAJOR_VERSIONS),\
-                 $(foreach PYTHON_MINOR, $(PYTHON_MINOR_VERSIONS),\
-                 python$(PYTHON_VERSION)))
-PYTHON_LIB = -l$@ /usr/lib/$@/site-packages/PIL/_imaging.so
-PYTHON_INCLUDES = -I/usr/include/$@
+python_targets = $(shell pyversions -s)
 
 ifneq (,$(wildcard /usr/bin/libart2-config))
 LIBART = libart2
@@ -110,8 +103,8 @@
        $(MAKE) -C lib/python clean
        # Fix the PYHTON_LIB and PYTHON_INCLUDES in the Makefile.common
        cp Makefile.common Makefile.common.bak
-       sed -i s,"\(PYTHON_LIB=\).*","\1$(PYTHON_LIB)", Makefile.common
-       sed -i s,"\(PYTHON_INCLUDES=\).*","\1$(PYTHON_INCLUDES)", 
Makefile.common
+       sed -i 
s,"^PYTHON_LIB=.*","PYTHON_LIB=/usr/lib/$@/site-packages/PIL/_imaging.so", 
Makefile.common
+       sed -i s,"^PYTHON_INCLUDES=.*","PYTHON_INCLUDES=-I/usr/include/$@", 
Makefile.common
        # Make the module
        $(MAKE) -C lib/python
        # Copy the module to safe, so we can compile another one
@@ -163,6 +156,8 @@
        dh_compress
        dh_fixperms
        dh_pysupport
+       dh_makeshlibs -V
+       dh_installdeb
        dh_shlibdeps
        dh_gencontrol
        dh_md5sums



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to