* Asheesh Laroia | 2008-12-14 11:31:48 [-0800]: > Upstream seems slow to answer if the patch is good, even for the previous > patch which was not. So let's see if we can sanity-check this without > upstream's help.
I've signed up to their mailing list and sent then the following email: --- The Debian package jack-audio-connection-kit-0.115.6 does not build on Alpha due to abuse of va_list [1] |client.c: In function 'jack_client_open_aux': |client.c:972: error: used struct type value where scalar is required |client.c: In function 'jack_client_new': |client.c:1120: error: incompatible type for argument 4 of |'jack_client_open_aux' va_list must not be used directly, only via helpers. Unfortunately only the alpha compiler complains. This patch has been only compile tested on amd64 and a similar version has been build tested on Alpha as you can seen in the Debian bug report #508114 [2]. I've just removed the if part since it should not make any difference. This patch is against r3204. Could upstream please verify the correctness of this patch? Sebastian [1] http://buildd.debian.org/fetch.cgi?pkg=jack-audio-connection-kit;ver=0.115.6-1;arch=alpha;stamp=1228082671/gcc [2] http://bugs.debian.org/508114 --- a/libjack/client.c +++ b/libjack/client.c @@ -974,10 +974,7 @@ jack_client_open_aux (const char *client } /* parse variable arguments */ - if (ap) jack_varargs_parse(options, ap, &va); - else - jack_varargs_init(&va); /* External clients need to know where the tmpdir used for communication with the server lives @@ -1122,7 +1119,7 @@ jack_client_new (const char *client_name jack_options_t options = JackUseExactName; if (getenv("JACK_START_SERVER") == NULL) options |= JackNoStartServer; - return jack_client_open_aux (client_name, options, NULL, NULL); + return jack_client_open(client_name, options, NULL); } char * --- And this is the answer I received: |On Sat, Dec 13, 2008 at 11:54:42PM +0100, torb...@gmx.de wrote: |> On Sat, Dec 13, 2008 at 09:30:18PM +0100, Sebastian Andrzej Siewior wrote: |> > The Debian package jack-audio-connection-kit-0.115.6 does not build on |> > Alpha due to abuse of va_list [1] |> > |> > |client.c: In function 'jack_client_open_aux': |> > |client.c:972: error: used struct type value where scalar is required |> > |client.c: In function 'jack_client_new': |> > |client.c:1120: error: incompatible type for argument 4 of |> > |'jack_client_open_aux' |> > |> > va_list must not be used directly, only via helpers. Unfortunately only |> > the alpha compiler complains. |> > This patch has been only compile tested on amd64 and a similar version |> > has been build tested on Alpha as you can seen in the Debian bug report |> > #508114 [2]. I've just removed the if part since it should not make any |> > difference. This patch is against r3204. |> > |> > Could upstream please verify the correctness of this patch? |> |> looks good to me. | |applied to my git... tested: |"jack_netsource -s server2" connects to second server. | |i commit when paul gives ok. |_______________________________________________ |Jack-Devel mailing list |jack-de...@lists.jackaudio.org |http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org So it seems that part of upstream is fine with it and tested it. Unfortunately you got to sign-up in order to see the archive. Does this sound okay to you? > -- Asheesh. Sebastian -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
