Hi Kees, On Sun, 26 Oct 2008, Kees Cook wrote:
How about this patch as an alternative, which doesn't change the semantics of the array, but makes sure it is aligned.
After applying only your patch, it still crashes in log_work.c. (So, I guess it works as well as my patch to super.c, although that wasn't the part I was worried about.)
I did think of patching super.c by specifying alignment, but didn't think upstream would accept use of GCC extensions. Also, declaring the array as what it is used as just seems cleaner overall, although it does allocate an extra 136 bytes on the stack. (Is that the semantic change you are worried about?)
Anyways, the semantic change I was worried about was the change to dip in log_work.c, since I'm not entirely sure whether something else might be changing *data.
Ivan -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
